← Back to issue list

states: add outdated step verification

View original Github issue

Metadata

Project
craft-parts
Number
#21
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #21 (commit 08e81f92, merge 0d39e299) adds outdated step verification to the state manager: a part step is outdated when an earlier step ran more recently; source-handler checks were deferred to a later PR.

Resolution: closed resolved

Reason: The PR was approved and merged into main as commit 08e81f92 via merge commit 0d39e299 ("Merge pull request #21 from cmatsuoka/import/state-management-5"), implementing step execution order verification in craft_parts/state_manager; the deferred source-handler check was added later in commit 0693f1b5 (PR #50).

Evaluated by: mr-cal-bot

No scores available.

Issue body

A part step is considered outdated if one of previous steps ran more recently, or if logic in the source handler for that part says so. This change implements the step execution order verification, leaving source checks to be added later (after source handlers are added to the codebase). Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #21 (commit 08e81f92, merge 0d39e299) adds outdated step verification to the state manager: a part step is outdated when an earlier step ran more recently; source-handler checks were deferred to a later PR.
stealth/space-bunny-alpha — closed resolved Approved and merged, adding outdated-step verification so part steps run after more recently executed previous steps; source-handler checks were deferred.
qwen/qwen3.6-35b-a3b — — Merged step execution order verification to detect outdated parts based on run times or handler logic. Approved by two reviewers, adding 343 lines across seven files. Source checks deferred.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation of outdated step verification for state execution. The change validates step order by checking if previous steps ran more recently or if source handler logic applies, deferring source checks to a future update.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#50 (confidence 80%)

    PR #50 (commit 0693f1b5 'sources: add source handler integration') added the source-handler outdated checks that PR #21 explicitly deferred.

Related issues

Issue Project State Summary Similarity
#23 states: add dirty step verification craft-parts merged Merged dirty-step verification: steps rerun when state properties/options change or dependencies require execution (craft-parts#23, ca487581).
77%
#24 states: add management methods to refresh and clean steps craft-parts merged Merged PR #24 added state-management methods to mark steps recently updated and clean obsolete in-memory state; merged in 9a1ee8dc via d7038420.
72%
#10 states: add step state base class craft-parts merged Merged PR #10 via commit 35d2dde5, adding a base class for step state that preserves execution context, detects relevant changes, and enables unchanged runs to be skipped.
72%