← Back to issue list

packages: fix symlink normalization

View original Github issue

Metadata

Project
craft-parts
Number
#215
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for symlink normalization that replaces Path.relative_to() with os.path.relpath() to correctly resolve parent path components. Approved by reviewer and passed CI checks.

Suggested action:

No scores available.

Issue body

Use `os.path.relpath()` instead of `Path.relative_to()` to normalize symlinks requiring parent path components. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for symlink normalization that replaces Path.relative_to() with os.path.relpath() to correctly resolve parent path components. Approved by reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for package symlink normalization by replacing Path.relative_to() with os.path.relpath() to correctly resolve parent path components.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3497 repo: fix regression in fix_symlink() snapcraft merged Merged a fix for a regression in fix_symlink() where copied files retained stale symlinks. The update ensures symlinks correctly point to new files and adds spread tests for relative and host copy scenarios. Approved by two reviewers and passed CI.
77%
#1684 fix: normalize leading slashes in migration paths craft-parts merged Merged fix normalizing leading slashes in migration paths to prevent absolute and relative path mismatches, resolving #507. Approved by two reviewers with all CI checks passing.
72%
#131 Respect the symlink even if it's a directory when building. charmcraft merged Merged a pull request updating the build process to respect symlinks pointing to directories. Approved by three reviewers, passed CI checks, and modified two files with 85 additions and 15 deletions.
70%