Info leaked to stdout when running subprocess
Metadata
Current evaluation
Subprocess output leakage was fixed by canonical/craft-parts#228, merged as commit 17522579.
Resolution: closed resolved
Reason: PR #228 made snap operations run silently and was merged into main as 17522579, with implementation commit 29ef1aa2.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There are several places that are calling a sub-process and its output is leaked to the terminal, when it shouldn't.
- `craft_parts/packages/snaps.py`
- two `check_call` calls
- `craft_parts/utils/os_utils.py`
- three `check_call` calls
Probably they should be converted to something like the following:
subprocess.run(..., stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
Note that calling `check_output` would fix the problem anyway, but in reality if the command output is not needed, it's better to discard it directly (send it to devnull) than store it in memory and then discard it (a `check_output` call without storing the result)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Subprocess output leakage was fixed by canonical/craft-parts#228, merged as commit 17522579. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed snap subprocess output leakage by PR #228, merged as commit 17522579. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. Subprocess stdout leakage in craft_parts was reported but never addressed or merged. | |
| qwen/qwen3.6-35b-a3b | — | — | Subprocess output leaking to stdout in snaps.py and os_utils.py was reported. The issue was closed without resolution or linked pull request, indicating it was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned. The reported subprocess stdout leakage in snaps.py and os_utils.py was not addressed, and the suggested DEVNULL redirection was never implemented. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Subprocess output leakage in craft_parts was closed without resolution. The suggested fix using subprocess.DEVNULL was not implemented. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-parts#228
(confidence 100%)
Merged fix for leaked snap subprocess output.
Related issues
No related issues found above the similarity threshold.