← Back to issue list

executor: fix update build stage packages

View original Github issue

Metadata

Project
craft-parts
Number
#234
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for build stage package update consistency and resolved unpacked files disappearing after build updates. Approved by two reviewers, passed CI, and integrated with 49 additions and 26 deletions across five files.

Suggested action:

No scores available.

Issue body

Make build step update execution consistent with the initial build step execution, and fix removal of the part install directory after stage packages and snaps are unpacked (causing unpacked files to disappear after a build update). Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1117

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for build stage package update consistency and resolved unpacked files disappearing after build updates. Approved by two reviewers, passed CI, and integrated with 49 additions and 26 deletions across five files.
qwen3.6-35b-a3b-mtp-q6 Merged fix aligning build step update execution with initial builds and resolving premature removal of the part install directory after stage packages and snaps unpack, preventing file loss during updates. (CRAFT-1117)

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#913 help: update stage-packages and build-packages snapcraft merged Merged documentation update for stage-packages and build-packages. Changes corrected outdated information and added elf crawling logic details. A minor phrasing comment was acknowledged but retained. Successfully merged after maintainer review.
76%
#1157 repo: support versioned stage-packages snapcraft merged Support for versioned stage-packages was successfully merged after approval from two reviewers. The contributor addressed feedback and resolved a local CLA issue, delivering a +94/-8 line change across four files.
73%
#235 Release 1.7.2 craft-parts merged Merged release 1.7.2 after single reviewer approval and passing CI. Resolves git repository update failures and corrects stage package removal during build updates across 13 files.
73%
#452 build(deps): update dependencies rockcraft merged Merged dependency update approved by two reviewers. The change modified four files with 62 additions and 64 deletions, successfully updating project dependencies without unresolved review comments.
72%
#5452 docs: migrate 'Build and staging dependencies' snapcraft merged Merged documentation update migrating the 'Build and staging dependencies' section. Approved by two reviewers with all CI checks passing. Four files were modified, adding 186 lines and removing six, successfully updating the documentation.
72%
#1290 tests: refactor tests with build and stage packages snapcraft merged Merged after approval. Refactored tests across 12 files to use build and stage packages, changing 115 lines added and 110 removed. Code coverage remained unchanged at 95.27% upon integration into master.
72%
#1493 build(deps): update dependencies charmcraft merged Merged pull request updating project dependencies. Approved by two reviewers, the maintainer addressed comments on unused packages and clarified that CI failures resulted from an external issue.
72%
#472 build(deps): update dependencies rockcraft merged Merged dependency updates across four files, modifying 57 additions and 58 deletions. Approved by two reviewers with passing CI checks. The maintainer-authored changes were integrated into the codebase without further comments.
71%
#1779 catkin-tools plugin: use stage-packages snapcraft merged Merged a fix switching the catkin-tools plugin from build-packages to stage-packages, resolving clean system failures. Added an integration test. Approved by two reviewers and passed CI.
71%
#834 fix: use partitions for stage-packages tracking craft-parts merged Merged to fix issue #804. The change updates stage-package tracking to scan primed files per partition, resolving failures in common partitioned setups. Multi-partition tracking still requires deeper refactoring. Approved by three reviewers and passed CI.
71%