← Back to issue list

executor: handle empty scriptlets

View original Github issue

Metadata

Project
craft-parts
Number
#242
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #242 via 4dd2a4a0 (merge 6bc69a69) to distinguish empty scriptlets from undefined ones, skipping the built-in handler.

Resolution: closed resolved

Reason: PR #242 was merged after approval. Commit 4dd2a4a0 implements the fix, with merge commit 6bc69a69 recording its integration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Empty scriptlets should be handled as such and not as undefined scriptlets. In the former case, the built-in handler for the step is not executed, the empty scriptlet is executed instead. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1182

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #242 via 4dd2a4a0 (merge 6bc69a69) to distinguish empty scriptlets from undefined ones, skipping the built-in handler.
stealth/space-bunny-alpha — closed resolved Merged PR #242 fixed empty scriptlet handling so an empty scriptlet runs instead of the built-in handler.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#242 via commit 4dd2a4a0, treating empty scriptlets as valid instead of invoking built-in step handlers; resolves CRAFT-1182.
qwen/qwen3.6-35b-a3b — — Updates executor to treat empty scriptlets as valid, executing them instead of falling back to built-in handlers. Merged after approval and passing CI checks. Resolves CRAFT-1182.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updates the executor to execute empty scriptlets instead of falling back to the built-in handler, resolving CRAFT-1182.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.