← Back to issue list

Revert "repo: fix_pkg_config trims prefixes more generically"

View original Github issue

Metadata

Project
craft-parts
Number
#255
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged a revert of commit f6681f0 that altered craft-part behavior when stage was in the working directory. Approved, passed CI, and restored the original fix_pkg_config prefix trimming logic.

Suggested action: —

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This reverts commit f6681f0fef39c38c1a4d3a7808d9e66cb884a369. This commit caused craft-part's behavior to change when `stage` is part of the pwd.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a revert of commit f6681f0 that altered craft-part behavior when stage was in the working directory. Approved, passed CI, and restored the original fix_pkg_config prefix trimming logic.
qwen3.6-35b-a3b-mtp-q6 — — Merged a revert of commit f6681f0 that modified prefix trimming in fix_pkg_config. The original change caused unintended behavior shifts in craft-part when the stage directory was in the working directory. The revert restores previous functionality.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#252 repo: fix_pkg_config trims prefixes more generically craft-parts merged Merged. Updates fix_pkg_config to generically strip prefixes, including the stage directory, when normalizing pkg-config files from staged snaps. Resolves LP #1916281 and CRAFT-1215. Approved and passed CI.
83%
#3848 repo: fix_pkg_config removes prefixes from staged snap's .pc files. snapcraft merged Merged a fix normalizing pkg-config prefixes in staged snaps by stripping prepended build directories. Squash-merged after review approval and full test coverage, resolving Launchpad #1916281 and CRAFT-1214.
76%
#251 repo: fix_pkg_config removes prefixes from staged snap's .pc files. craft-parts merged Merged fix normalizing pkg-config files from staged snaps by stripping prepended build directories from the prefix parameter. Resolves Launchpad bug #1916281 and CRAFT-1215. Approved and merged.
75%