Revert "repo: fix_pkg_config trims prefixes more generically"
Metadata
Current evaluation
Merged #255, reverting f6681f0f to undo generic pkg-config prefix trimming that changed behavior when "stage" appeared in the working directory path.
Resolution: closed resolved
Reason: PR #255 was approved and merged, explicitly reverting commit f6681f0fef39c38c1a4d3a7808d9e66cb884a369 to restore the prior behavior.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
This reverts commit f6681f0fef39c38c1a4d3a7808d9e66cb884a369.
This commit caused craft-part's behavior to change when `stage` is part of the pwd.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #255, reverting f6681f0f to undo generic pkg-config prefix trimming that changed behavior when "stage" appeared in the working directory path. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #255 reverted f6681f0f, restoring prior pkg-config prefix handling after generic trimming broke working-directory paths containing "stage". | |
| stealth/space-bunny-alpha | — | closed superseded | Merged #255, reverting f6681f0f because generic pkg-config prefix trimming broke craft-part behavior when “stage” appeared in the working directory path. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a revert of commit f6681f0 that altered craft-part behavior when stage was in the working directory. Approved, passed CI, and restored the original fix_pkg_config prefix trimming logic. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a revert of commit f6681f0 that modified prefix trimming in fix_pkg_config. The original change caused unintended behavior shifts in craft-part when the stage directory was in the working directory. The revert restores previous functionality. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #252 repo: fix_pkg_config trims prefixes more generically | craft-parts | merged | Merged: generic pkg-config prefix trimming (f6681f0f, merge 789d2510), follow-up to #251 for CRAFT-1215/LP#1916281. Later reverted by #255 (e7f3fe49) after false matches when 'stage' appeared in the working-directory path. | |
| #3848 repo: fix_pkg_config removes prefixes from staged snap's .pc files. | snapcraft | merged | Merged in snapcraft#3848 as commit 2dadaa6da, fixing fix_pkg_config to remove build-stage prefixes from staged snaps' pkg-config .pc files. | |
| #251 repo: fix_pkg_config removes prefixes from staged snap's .pc files. | craft-parts | merged | Merged in craft-parts#251 via 7c8140f4 (commit 359d377a), stripping staged build paths from .pc prefixes before applying the new prefix, addressing LP #1916281. |