← Back to issue list

lint: set a timeout in `requests.get()`

View original Github issue

Metadata

Project
craft-parts
Number
#270
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #270 as commit 81263be5, adding a 10-second timeout to requests.get() calls to address pylint 2.15's missing-timeout warning.

Resolution: closed resolved

Reason: The approved PR was merged as commit 81263be5, setting timeout=10 on the affected requests.get() calls and resolving the potentially endless-request lint warning.

Evaluated by: mr-cal-bot

No scores available.

Issue body

pylint 2.15 adds a new warning on timeout-less calls to `requests.get()`, as it's a potentially endless call. The value of 10 seconds is arbitrary and can change if needed. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #270 as commit 81263be5, adding a 10-second timeout to requests.get() calls to address pylint 2.15's missing-timeout warning.
stealth/space-bunny-alpha — closed resolved Merged in PR #270 via commit 81263be5, adding a 10-second timeout to requests.get() calls to address pylint 2.15's no-timeout warning.
stealth/space-bunny-alpha — closed resolved Merged lint fix for pylint 2.15, adding a 10-second timeout to requests.get() to prevent potentially endless HTTP calls.
qwen/qwen3.6-35b-a3b — — Merged changes adding a 10-second timeout to requests.get calls to resolve a pylint 2.15 linting warning about potentially endless network requests. Approved by one reviewer, passed CI, and modified two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix adding a 10-second timeout to requests.get() calls to resolve a pylint 2.15 warning about potentially endless network requests. Authored by maintainer tigarmo with no further discussion.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.