← Back to issue list

filters: fix stage/prime filter combination

View original Github issue

Metadata

Project
craft-parts
Number
#280
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #280 (commit b26c06fc) corrected reversed stage/prime filter combination and added tests matching Snapcraft 6.x behavior.

Resolution: closed resolved

Reason: PR #280 was merged as commit b26c06fc, fixing the reversed filter computation and adding regression tests for combined stage and prime filters.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Filter combination was computed with filters reversed, resulting in unexpected behavior when both stage and prime filters are defined. Fix and add additional test cases matching Snapcraft 6.x tests and results. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-1377

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #280 (commit b26c06fc) corrected reversed stage/prime filter combination and added tests matching Snapcraft 6.x behavior.
stealth/space-bunny-alpha — closed resolved Merged PR #280 (commit b26c06fc), fixing reversed stage/prime filter combination and adding Snapcraft 6.x-matching tests.
stealth/space-bunny-alpha — closed resolved Merged PR #280 (commit b26c06fc) corrected reversed stage/prime filter composition and added Snapcraft 6.x-matching test cases.
qwen/qwen3.6-35b-a3b — — Merged fix for reversed stage/prime filter combination logic causing unexpected behavior. Added test cases, approved by reviewer, passed CI, and resolved CRAFT-1377.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for reversed stage/prime filter combination logic causing unexpected behavior. Added test cases aligned with Snapcraft 6.x to validate correct filter application. Resolves CRAFT-1377.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1006 schema: replace `snap` filter with `prime` filter. snapcraft merged Merged #1006 replaced the `snap` project filter with `prime`, deprecated `snap`, rejected configurations using both, and added a warning test; it fixes LP #1627781.
71%