executor: take permissions into account for collisions
Metadata
Current evaluation
Merged in craft-parts#305 via commit b93c135d, updating collision detection to account for differing permission definitions.
Resolution: closed resolved
Reason: PR #305 was approved and merged as commit b93c135d. It now flags overlapping paths with incompatible permission definitions as collisions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Two paths are considered to be colliding if they both have permissions definitions. The definitions are not "evaluated" to see if they possibly match (that is, if both sets of definitions would generate the same result) for simplicity, but this can be improved in the future.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-parts#305 via commit b93c135d, updating collision detection to account for differing permission definitions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-parts PR #305: executor collision detection now treats paths with permission definitions as colliding, using a simplified overlap check. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates the executor to flag path collisions when both paths have permission definitions. Uses a simplified check without evaluating matching definitions. Approved by one reviewer, passed CI, and changed six files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged executor update that flags paths with permissions definitions as collisions. Definitions are not evaluated for matching results to maintain simplicity, with potential future improvements noted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #52 executor: add part file collision verification | craft-parts | merged | Merged PR #52 via commit a287b91e (implementation commit 77630113), adding craft_parts/executor/collisions.py to verify parts don't stage identically-named files with differing contents; logic ported from snapcraft. |