← Back to issue list

executor: fix directory cleaning

View original Github issue

Metadata

Project
craft-parts
Number
#345
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged fix for issue #329 that corrects executor directory cleaning logic, preventing lifecycle directories from persisting after cleanup. Approved by one reviewer and passed CI checks.

Suggested action: —

No scores available.

Issue body

Fix bad logic in the executor cleaning that could lead to lifecycle directories that should be cleaned unexpectedly remaining after clean is issued. Thanks to Facundo Batista for spotting this bug, fixes #329. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged fix for issue #329 that corrects executor directory cleaning logic, preventing lifecycle directories from persisting after cleanup. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix correcting executor directory cleaning logic that left lifecycle directories unremoved after the clean command. Resolves #329.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1208 fix(executor): clean overlay directories craft-parts merged Merged fix for overlay directory cleanup in the executor, resolving #1207 and CRAFT-4697. Approved by four reviewers, passed all CI checks, and modified three files with 57 additions. No changelog entry was added.
76%
#106 executor: fix rerun action to clean subsequent steps (CRAFT-441) craft-parts merged Merged fix ensuring the executor invalidates and cleans subsequent steps during a rerun. Previously only the re-executed step was cleared. Approved by two reviewers and passed CI.
74%
#3719 tests: fix lifecycle tests to run on new directory snapcraft merged Merged a fix for lifecycle tests to run in a new directory instead of the current one. Approved by a reviewer, passed CI, and changed three lines.
70%