← Back to issue list

executor: fix directory cleaning

View original Github issue

Metadata

Project
craft-parts
Number
#345
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #345 fixed executor cleanup logic in commit b0086bbe, preventing lifecycle directories from unexpectedly remaining and resolving #329.

Resolution: closed resolved

Reason: Merged PR canonical/craft-parts#345 (commit b0086bbe) corrected cleanup behavior when an earlier directory was missing and resolved canonical/craft-parts#329.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fix bad logic in the executor cleaning that could lead to lifecycle directories that should be cleaned unexpectedly remaining after clean is issued. Thanks to Facundo Batista for spotting this bug, fixes #329. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #345 fixed executor cleanup logic in commit b0086bbe, preventing lifecycle directories from unexpectedly remaining and resolving #329.
stealth/space-bunny-alpha — closed resolved Merged PR #345 (b0086bbe), fixing executor clean logic so lifecycle directories no longer remain unexpectedly; resolves #329.
qwen/qwen3.6-35b-a3b — — Merged fix for issue #329 that corrects executor directory cleaning logic, preventing lifecycle directories from persisting after cleanup. Approved by one reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix correcting executor directory cleaning logic that left lifecycle directories unremoved after the clean command. Resolves #329.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#329 Executor clean may not be 100% effective craft-parts closed Fixed by merged PR canonical/craft-parts#345 ("executor: fix directory cleaning", commit b0086bbe), which replaced the suppress(FileNotFoundError) block with per-directory existence checks so all lifecycle dirs are removed.
75%
#1207 Overlay directory is not removed on a clean craft-parts closed Fixed in merged PR #1208 (commit bea8d2dc), which removes executor overlay directories during cleanup.
72%
#1208 fix(executor): clean overlay directories craft-parts merged Merged into main as commit bea8d2dc, fixing #1207/CRAFT-4697 by removing overlay directories during executor cleanup; all CI checks passed.
72%