← Back to issue list

plugins: verify plugin method override

View original Github issue

Metadata

Project
craft-parts
Number
#353
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #353 in commit 78cbc145, adding @override checks to inherited plugin methods across 14 files.

Resolution: closed resolved

Reason: The pull request was merged into main as commit 78cbc145, adding @override decorators so type checking verifies plugin method overrides.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use the `@override` decorator to ensure plugin methods correctly overrode an inherited method. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #353 in commit 78cbc145, adding @override checks to inherited plugin methods across 14 files.
stealth/space-bunny-alpha — closed resolved Merged PR #353, adding @override checks across 14 plugin files to verify inherited-method overrides.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks, the change adds the @override decorator across 14 files to enforce correct overriding of inherited plugin methods, improving type safety and code correctness.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Added the @override decorator to enforce correct overriding of inherited plugin methods, improving type safety. Approved by maintainer lengau.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.