← Back to issue list

utils: remove Ubuntu-specific code from OsRelease

View original Github issue

Metadata

Project
craft-parts
Number
#356
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #356 as commit 62c65491, removing 62 lines of Ubuntu-specific OsRelease code across two files and resolving CRAFT-1584.

Resolution: closed resolved

Reason: The approved PR was merged as commit 62c65491, deleting the Ubuntu-specific OsRelease logic. Follow-up linting concerns were addressed by merged PRs #358 and #359.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes CRAFT-1584 - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #356 as commit 62c65491, removing 62 lines of Ubuntu-specific OsRelease code across two files and resolving CRAFT-1584.
stealth/space-bunny-alpha — closed resolved Merged PR #356 in commit 62c65491, removing 62 lines of Ubuntu-specific OsRelease code across two files and resolving CRAFT-1584.
qwen/qwen3.6-35b-a3b — — Merged to remove Ubuntu-specific code from the OsRelease utility, resolving CRAFT-1584. Approved by reviewer, passed CI, and deleted 62 lines across two files after addressing linting rules in related PRs.
qwen3.6-35b-a3b-mtp-q6 — — Merged after removing Ubuntu-specific code from the OsRelease utility, resolving CRAFT-1584. Linting conflicts were resolved by disabling new ruff rules and applying fixes from related PRs #358 and #359.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#358 (confidence 95%)

    Follow-up PR pinning the Ruff version to prevent unintended CI lint breakage.

  • Related To: canonical/craft-parts#359 (confidence 95%)

    Follow-up PR updating linters and fixing remaining lint violations.

Related issues

Issue Project State Summary Similarity
#1569 feat: deprecate OsRelease in favor of distro craft-parts closed Closed unmerged and superseded by canonical/craft-parts#1581, which carries forward the OsRelease deprecation in favor of distro.
70%