← Back to issue list

plugins: fix pip path in python plugin

View original Github issue

Metadata

Project
craft-parts
Number
#392
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged a fix ensuring the python plugin uses the venv pip path, preventing unintended package installations when PATH changes. Approved by one reviewer, passed CI checks, and modified five files.

Suggested action: —

No scores available.

Issue body

Make sure the plugin uses pip from the venv it created, to prevent installing packages in unexpected locations if PATH is changed. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a fix ensuring the python plugin uses the venv pip path, preventing unintended package installations when PATH changes. Approved by one reviewer, passed CI checks, and modified five files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix ensuring the Python plugin uses the virtual environment's pip path. This prevents packages from installing in unintended locations when the system PATH changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#389 plugins: refactor python plugin for subclassing craft-parts merged Merged a refactor of the Python plugin to enable subclassing and method overriding for custom interpreter location logic. Approved by one reviewer, passed CI checks, and modified three files.
75%
#311 plugins: fix python shebang rockcraft merged Merged a fix for the Python shebang in plugins. The change replaces hardcoded interpreters with ${PARTS_PYTHON_INTERPRETER} to respect user overrides. Approved by two reviewers and merged.
74%
#393 Release 1.18.3 craft-parts merged Merged release 1.18.3, documenting a fix for the pip path in the Python plugin. Approved by one reviewer, passed CI, and successfully integrated.
73%
#882 Python plugin: remove pip packages when cleaning pull. snapcraft merged Resolved Launchpad bug #1630005 by removing the part directory packages during the Python plugin pull step cleanup. Merged following reviewer approval and passing CI checks, updating two files.
73%
#1549 plugins: extract pip from python plugin snapcraft merged Merged a refactor extracting the pip wrapper from the Python plugin. Introduces a public API to improve reusability and testability. Approved by two reviewers with passing CI checks, advancing a larger plugin extraction effort.
73%
#67 plugins: add python plugin craft-parts merged Merged a Python plugin ported from snapcraft. Approved by two reviewers, passed CI, and added 332 lines across five files to extend plugin support.
73%
#3041 V2 python plugin snapcraft merged Merged after approval. The changes implement the V2 python plugin across 14 files. CI checks passed. A reviewer noted a runtime executable error, but the pull request was integrated regardless.
71%
#1319 docs: add new Python plugin to the changelog craft-parts merged Merged after approval from two reviewers. The pull request documents a new Python plugin by adding an entry to the changelog. CI checks passed and changes were integrated into the main branch.
71%
#384 plugins: refactor python plugin for subclassing craft-parts merged Merged after review and CI approval. Refactored the Python plugin to enable subclassing and method overriding, allowing custom logic for determining the interpreter location. Rebased on main prior to merge.
71%
#1361 pluginhandler: don't clobber path on local import failure snapcraft merged Merged fix preventing sys.path clobbering on local plugin import failure. Implemented a try/finally block to restore the path. Approved by two reviewers and passed CI.
71%