← Back to issue list

plugins: fix pip path in python plugin

View original Github issue

Metadata

Project
craft-parts
Number
#392
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #392 (commit 60858e8f, maintainer cmatsuoka) merged: the Python plugin now resolves pip from the venv it creates instead of bare 'pip', so altered PATH cannot install packages elsewhere. Still present in HEAD via _get_pip().

Resolution: closed resolved

Reason: Merged into main as commit 60858e8f ('plugins: fix pip path in python plugin (#392)'), approved with 0 unresolved comments. The change introduced _get_pip() returning '<venv dir>/bin/pip', which is still used by poetry_plugin.py and the base Python plugin at HEAD.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Make sure the plugin uses pip from the venv it created, to prevent installing packages in unexpected locations if PATH is changed. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #392 (commit 60858e8f, maintainer cmatsuoka) merged: the Python plugin now resolves pip from the venv it creates instead of bare 'pip', so altered PATH cannot install packages elsewhere. Still present in HEAD via _get_pip().
stealth/space-bunny-alpha — closed resolved Merged plugins fix: the Python plugin now uses pip from the venv it creates, preventing unexpected package installations when PATH changes.
stealth/space-bunny-alpha — closed resolved Merged PR #392 (commit 60858e8f), fixing the Python plugin to use pip from its created venv and avoid PATH-dependent installations.
qwen/qwen3.6-35b-a3b — — Merged a fix ensuring the python plugin uses the venv pip path, preventing unintended package installations when PATH changes. Approved by one reviewer, passed CI checks, and modified five files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix ensuring the Python plugin uses the virtual environment's pip path. This prevents packages from installing in unintended locations when the system PATH changes.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#389 (confidence 40%)

    Prior 'plugins: refactor python plugin for subclassing' commit (b23e45b2) immediately preceding this fix in python_plugin.py history.

Related issues

No related issues found above the similarity threshold.