← Back to issue list

chroot: mark /dev mount as private

View original Github issue

Metadata

Project
craft-parts
Number
#400
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged fix marking /dev mount as private to prevent shared mount propagation in chroots. Resolves unmount cascading caused by rootfs becoming a shared mount, addressing rockcraft#195. Approved and passed CI.

Suggested action:

No scores available.

Issue body

Address shared mount issues affecting /dev mount in chroots. This is a result of https://github.com/lxc/lxc/pull/4229 (container rootfs became a shared mount, meaning that unmounts propagates through the shared group and original mounts are unmounted too). See https://github.com/canonical/rockcraft/issues/195 for details. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix marking /dev mount as private to prevent shared mount propagation in chroots. Resolves unmount cascading caused by rootfs becoming a shared mount, addressing rockcraft#195. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged. Marks the /dev mount as private in chroots to stop unmount propagation from the shared container rootfs added in PR #4229. Closes rockcraft issue #195.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1348 fix: Make mounted devices private before recursively unmounting the chroot craft-parts merged Merged fix that remounts chroot devices as private before recursive unmounting to properly handle submounts. Resolves #1344. Approved by reviewers and passed all CI checks.
85%
#295 chroot: fix device nodes in overlay base image craft-parts merged Merged. Replaced standard bind mounts with rbind to fix device nodes failing to appear in containers. Approved by a reviewer and passed CI checks.
74%
#401 Release 1.18.4 craft-parts merged Merged release 1.18.4 by maintainer cmatsuoka. Changes make the chroot /dev mount private. Approved by one reviewer with no unresolved comments.
73%
#1344 More robust chroot unmounting craft-parts closed Closed and superseded by internal Jira ticket CRAFT-4804. No code changes were merged. The proposed --make-rprivate and --recursive unmounting fix remains unimplemented.
72%