steps: handle overlay feature in step lists
Metadata
Current evaluation
Merged after reviewer approval and passing CI. The change updates step list logic to exclude the overlay step when the feature is disabled, modifying 10 files with 184 additions and 13 deletions.
Suggested action: —
No scores available.
Issue body
When the overlay feature is disabled, the lists of next and previous steps for any given step must not list the overlay step.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI. The change updates step list logic to exclude the overlay step when the feature is disabled, modifying 10 files with 184 additions and 13 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer cmatsuoka. The overlay step is now excluded from next and previous step lists when the overlay feature is disabled. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #137 many: add overlay step (CRAFT-84) | craft-parts | merged | Merged. Adds an overlay step to process filesystem mutations like package installation and file modifications across parts. Updates multiple subsystems and tests, approved by a reviewer, passed CI, and maintains fast execution. | |
| #1261 feat: reorder steps if organizing to overlay | craft-parts | merged | Merged after approval and passing CI checks. The update reorders build steps for overlay-organizing parts, ensuring content organization runs immediately after the overlay step to satisfy ST-158 requirements. | |
| #1190 fix(overlay): detect conflicts between overlay and install | craft-parts | merged | Merged fix enhancing Stage step collision detection to account for overlay contents, preventing conflicts with install directories. Includes integration tests, passed all CI checks, and received approval from three reviewers. | |
| #407 features: reorganize overlay feature tests | craft-parts | merged | Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI. | |
| #135 executor: add overlay step handling (CRAFT-86) | craft-parts | merged | Merged. Adds overlay step handling to the executor, mounting the overlay stack during builds so parts with overlay visibility can access the filesystem for package installation and user scripts. Approved and passed CI. | |
| #365 docs: include overlays in the lifecycle documentation. | craft-parts | merged | Merged documentation update adding overlay information to the lifecycle guide. Approved by two reviewers. A lint issue was addressed separately in PR #366. Changes modified 4 files with 85 additions and 1 deletion. | |
| #1472 feat: add override-overlay | craft-parts | merged | Merged the override-overlay feature. Approved by two reviewers with 180 additions and 35 deletions across 10 files. Passed required CI checks and was successfully integrated into the codebase. | |
| #795 docs: add labels for overlay step | craft-parts | merged | Merged documentation update adding labels for the overlay step. Fixes a reference issue for applications excluding the overlay explanation page and unblocks CRAFT-3043. Approved by two reviewers and passed CI checks. | |
| #1473 docs: add override-overlay | craft-parts | merged | Merged documentation update adding override-overlay. Approved by three reviewers and passed CI checks despite two failing edge tests. Changes span six files with 20 additions and 8 deletions. | |
| #1618 fix: handle dependencies when organizing to overlay | craft-parts | merged | Merged following approval and successful CI checks. Resolves dependency ordering during overlay organization by prioritizing BUILD steps over dependency STAGE steps, fixing issue #1611. Code was rebased on main prior to integration. |