← Back to issue list

steps: handle overlay feature in step lists

View original Github issue

Metadata

Project
craft-parts
Number
#406
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #406 as commit ae096471, making previous/next step lists omit the overlay step when the overlay feature is disabled.

Resolution: closed resolved

Reason: PR #406 was merged as commit ae096471. It gates overlay entries in both previous_steps() and next_steps() on Features().enable_overlay.

Evaluated by: mr-cal-bot

No scores available.

Issue body

When the overlay feature is disabled, the lists of next and previous steps for any given step must not list the overlay step. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #406 as commit ae096471, making previous/next step lists omit the overlay step when the overlay feature is disabled.
stealth/space-bunny-alpha — closed resolved Merged #406 via ae096471, excluding overlay steps from previous/next step lists when the overlay feature is disabled.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#406 via commit ae096471, excluding the overlay step from previous/next step lists when the overlay feature is disabled.
qwen/qwen3.6-35b-a3b — — Merged after reviewer approval and passing CI. The change updates step list logic to exclude the overlay step when the feature is disabled, modifying 10 files with 184 additions and 13 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer cmatsuoka. The overlay step is now excluded from next and previous step lists when the overlay feature is disabled.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1261 feat: reorder steps if organizing to overlay craft-parts merged Merged in commit 55d01a3f, PR #1261 runs BUILD after OVERLAY for parts organizing to overlay so organized content is available to parts installing overlay packages.
72%
#135 executor: add overlay step handling (CRAFT-86) craft-parts merged Merged PR #135 via b7527d5b, adding overlay-step execution handling that mounts the overlay stack during builds.
72%