← Back to issue list

Remove items from `directories` list after iteration

View original Github issue

Metadata

Project
craft-parts
Number
#417
Type
pull request
State
merged
Author
carlcsaposs-canonical
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for issue #416 that prevents skipped items when modifying the directories list during iteration. Approved by one reviewer, passed CI, and applied a +4/-1 change to one file.

Suggested action:

No scores available.

Issue body

Fixes #416 Removing items from a list while iterating though that list (in a for loop) causes items in the list to be skipped in the for loop

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for issue #416 that prevents skipped items when modifying the directories list during iteration. Approved by one reviewer, passed CI, and applied a +4/-1 change to one file.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for issue #416 addressing a bug where modifying the directories list during iteration skipped elements. Items are now removed after the loop completes to ensure all entries are processed correctly.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#87 A test for directories in the copy plugin snapcraft merged Merged a test addition verifying the fix for issue #16 regarding directories in the copy plugin. The change adds seven lines across three files and was accepted without review or CI checks.
71%