← Back to issue list

Remove items from `directories` list after iteration

View original Github issue

Metadata

Project
craft-parts
Number
#417
Type
pull request
State
merged
Author
carlcsaposs-canonical
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #417 as commit e7018745, fixing #416 by removing processed entries after iteration so Charmcraft PULL no longer skips updated directories.

Resolution: closed resolved

Reason: The approved PR was merged as commit e7018745. It fixes #416 by removing directories from the list after iteration, preventing subsequent entries from being skipped.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #416 Removing items from a list while iterating though that list (in a for loop) causes items in the list to be skipped in the for loop

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #417 as commit e7018745, fixing #416 by removing processed entries after iteration so Charmcraft PULL no longer skips updated directories.
stealth/space-bunny-alpha — closed resolved Merged craft-parts#417 as commit e7018745, fixing skipped directories by removing local_source.py items after iteration and resolving #416.
qwen/qwen3.6-35b-a3b — — Merged a fix for issue #416 that prevents skipped items when modifying the directories list during iteration. Approved by one reviewer, passed CI, and applied a +4/-1 change to one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for issue #416 addressing a bug where modifying the directories list during iteration skipped elements. Items are now removed after the loop completes to ensure all entries are processed correctly.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#416 (confidence 100%)

    The missing-directory tracking issue fixed by PR #417 and commit e7018745.

Related issues

Issue Project State Summary Similarity
#416 Updated directory missing in `charmcraft` pull step craft-parts closed Fixed skipped updated directories during Charmcraft PULL by merging craft-parts#417 (commit e7018745), which safely removes entries after iteration.
77%