← Back to issue list

executor: fix subdir in pull and build steps

View original Github issue

Metadata

Project
craft-parts
Number
#442
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #442 merged the source-subdir working-directory fix, but its commits (4129bdb7, 1c787237) were later reverted by dcbc4747 and 28ca6974.

Resolution: closed resolved

Reason: PR #442 was merged, meeting the merged-PR resolution criterion. However, commits dcbc4747 and 28ca6974 later reverted the fix following concerns about breaking Snapcraft, so the change was not retained.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The working directories for the pull and build steps should also be set accordingly when source-subdir is set. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #442 merged the source-subdir working-directory fix, but its commits (4129bdb7, 1c787237) were later reverted by dcbc4747 and 28ca6974.
stealth/space-bunny-alpha — closed superseded Merged in canonical/craft-parts#442, but commits dcbc4747 and 28ca6974 later reverted the source-subdir working-directory fix.
qwen/qwen3.6-35b-a3b — — Merged fix aligning pull and build step working directories with source-subdir settings. Approved by two reviewers and passed CI. Reviewers noted potential Snapcraft breakage and recommended noting workaround removal in release notes.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix ensuring pull and build steps correctly apply the working directory when source-subdir is configured. Release notes were requested to document a workaround removal, and potential Snapcraft breakage was noted.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.