executor: fix subdir in pull and build steps
Metadata
Current evaluation
Merged fix aligning pull and build step working directories with source-subdir settings. Approved by two reviewers and passed CI. Reviewers noted potential Snapcraft breakage and recommended noting workaround removal in release notes.
Suggested action: —
No scores available.
Issue body
The working directories for the pull and build steps should
also be set accordingly when source-subdir is set.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix aligning pull and build step working directories with source-subdir settings. Approved by two reviewers and passed CI. Reviewers noted potential Snapcraft breakage and recommended noting workaround removal in release notes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix ensuring pull and build steps correctly apply the working directory when source-subdir is configured. Release notes were requested to document a workaround removal, and potential Snapcraft breakage was noted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1601 snapcraft.yaml: don't re-use build dir | snapcraft | merged | Merged a fix for a source-build directory clash in snapcraft.yaml. The build directory was renamed to apt-build to avoid scriptlet conflicts. Approved by reviewers and passed CI, resolving the failure. | |
| #3154 cmake v2 plugin: take source-subdir into account | snapcraft | merged | Merged. Updates cmake v2 plugin to use SNAPCRAFT_PART_SOURCE_WORK instead of SNAPCRAFT_PART_SOURCE for pull and build steps, fixing source subdirectory handling. Approved, passed CI, and modified 10 files (+55/-7). | |
| #2256 local source: don't include .snapcraft directory | snapcraft | merged | Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files. | |
| #1548 fix: revert organize from build | craft-parts | merged | Merged to revert commit 8e4daf5, resolving a Snapcraft regression caused by the organize-from-build feature. Approved by two reviewers and verified downstream. The feature will be reintroduced once underlying issues are resolved. | |
| #2309 snap: improve early base detection logic | snapcraft | merged | Merged. Resolved early base detection failure in build providers by updating logic to account for snapcraft's non-project directory execution. Approved by reviewer, passed CI, and merged with minimal changes. | |
| #2299 docs: fix formatting issues | charmcraft | merged | Merged documentation formatting fixes resolving local build errors. Approved by two reviewers with minimal changes (+3/-1 across two files). Merged despite failing snap-build CI checks. | |
| #299 fix(remote-build): minor edge cases found with snapcraft | craft-application | merged | Fixed minor snapcraft edge cases in remote builds. Merged following approval by two reviewers and passing CI checks. The update modifies three files, adding 43 lines and removing 13. |