← Back to issue list

Base _setup_wait_for_system_ready should use systemctl's --wait parameter

View original Github issue

Metadata

Project
craft-parts
Number
#472
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed by maintainer lengau as misfiled (2023-06-09): the `_setup_wait_for_system_ready` logic lives in craft-providers, not craft-parts. Work tracked in canonical/craft-providers#304, still open.

Resolution: closed superseded

Reason: Maintainer lengau commented "Closing this as I should have put it in craft-providers, not here", and the same proposal was re-filed as canonical/craft-providers#304, which remains open (unimplemented, needing CentOS 7 override plus a Xenial/ESM decision). No corresponding code or commits exist in craft-parts, confirming the fix never belonged here.

Evaluated by: mr-cal-bot

No scores available.

Issue body

https://github.com/canonical/craft-providers/blob/778490b9b1601a0ccc052c9a9bb59b1ccf81e5a3/craft_providers/base.py#L315 CentOS 7 and Ubuntu Xenial don't `systemctl is-system-running --wait`. However, we can override this in the centos base. For Xenial we can either override it in the BuilddBase if the alias is Xenial or we can drop Xenial support if we don't need to support ESM.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed by maintainer lengau as misfiled (2023-06-09): the `_setup_wait_for_system_ready` logic lives in craft-providers, not craft-parts. Work tracked in canonical/craft-providers#304, still open.
stealth/space-bunny-alpha — closed superseded Closed without implementation as misplaced; tracking moved to the still-open canonical/craft-providers#304.
qwen/qwen3.6-35b-a3b — — Closed and abandoned as misplaced; the suggestion belongs in the craft-providers repository instead. No action taken here.
qwen/qwen3.6-35b-a3b — — Closed as invalid. The author filed the issue in the wrong repository and noted it should have been submitted to craft-providers instead. No changes were made here.
qwen/qwen3.6-35b-a3b — — Closed by the author as misplaced. The suggestion to implement systemctl's --wait parameter for _setup_wait_for_system_ready was intended for the craft-providers repository. No action taken here.
qwen3.6-35b-a3b-mtp-q6 — — Closed as misfiled. The author noted the systemctl --wait enhancement belongs in the craft-providers repository. No changes applied here.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/craft-providers#304 (confidence 95%)

    Identical title and body; the re-filed upstream issue where Base._setup_wait_for_system_ready must use systemctl is-system-running --wait, still open.

Related issues

Issue Project State Summary Similarity
#304 Base _setup_wait_for_system_ready should use systemctl's --wait parameter craft-providers open Enhancement to replace polling of systemctl is-system-running with native --wait; it remains unimplemented and needs CentOS 7 handling plus a Xenial compatibility decision.
77%