← Back to issue list

fix(parts): validate part dependency name

View original Github issue

Metadata

Project
craft-parts
Number
#558
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #558 (9a338194), validating undefined part dependency names and fixing #539; #569 carried the fix into main as b43d917f.

Resolution: closed resolved

Reason: PR #558 was merged with commit 9a338194, adding validation that raises InvalidPartName for nonexistent part dependencies. PR #569 also merged the change into main as b43d917f.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Raise an error if a part depends on a non-existing part name. Fixes: #539 - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Example output from application: ``` $ snapcraft --destructive-mode Initializing parts lifecycle :: A part named 'trololo' is not defined in the parts list. Review the parts definition and make sure it's correct. ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #558 (9a338194), validating undefined part dependency names and fixing #539; #569 carried the fix into main as b43d917f.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-parts#558, validating part dependencies and rejecting undefined part names; the same fix landed through #569 (9a338194/b43d917f).
qwen/qwen3.6-35b-a3b — — Merged fix for #539 that validates part dependency names. The change raises an error when a part references a non-existent dependency, approved by two reviewers and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged by cmatsuoka to fix #539. Adds validation for part dependency names, raising an error when a part references a non-existent dependency to prevent silent build failures.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#569 fix(parts): validate part dependency name craft-parts merged Merged PR #569 via commit b43d917f, applying #558 to validate part dependency names and reject nonexistent parts, fixing #539.
94%