← Back to issue list

test: fix mock chroot fixture

View original Github issue

Metadata

Project
craft-parts
Number
#575
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a one-line fix for the mock chroot test fixture to ensure Python 3.11 compatibility, aligning with upstream CPython changes. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- I caught this when running the tests in Python 3.11. The upstream change was https://github.com/python/cpython/pull/31090

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a one-line fix for the mock chroot test fixture to ensure Python 3.11 compatibility, aligning with upstream CPython changes. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the mock chroot fixture to resolve Python 3.11 test failures, aligning with upstream CPython change #31090.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#439 tests: protect fixture against chdir mocks craft-parts merged Merged updates to the new_dir test fixture to always call the original os.chdir. This prevents unexpected behavior when tests mock the function. Approved by one reviewer and modified three files.
71%
#118 tests: use tmp_path instead of mock_path rockcraft merged Merged a unit test fix replacing mock_path with tmp_path to resolve fixture scope issues. Approved by one reviewer, passed CI, and modified 1 file (+3/-3 lines).
71%