← Back to issue list

build(deps): pin overrides!=7.6.0

View original Github issue

Metadata

Project
craft-parts
Number
#628
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #628 (commit 5ad7be9c): pinned overrides!=7.6.0 in pyproject.toml to exclude the buggy upstream 7.6.0 release that broke Python plugin tests using @override on superclass methods. Same pin backported to main via #630 (694b8e96); pin later dropped in #1268.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged as 5ad7be9c, adding the overrides!=7.6.0 constraint to pyproject.toml to restore tests failing with "No super class method found". The same pin was merged to main as #630 (694b8e96).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- `overrides` 7.6.0 introduced a bug: https://github.com/mkorpela/overrides/issues/121 A handful of python plugin tests are failing with: ``` FAILED tests/integration/plugins/test_python.py::test_python_plugin_no_system_interpreter[True] - TypeError: test_python_plugin_no_system_interpreter.<locals>.MyPythonPlugin._get_system_python_interpreter: No super class method found ``` due to how the tests override superclass functions: ``` class MyPythonPlugin(craft_parts.plugins.plugins.PythonPlugin): @override def _get_system_python_interpreter(self) -> Optional[str]: return None ``` Our options are: 1. Merge this PR 2. Use the workaround described in the bug linked above 3. Wait for a fix in `overrides`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #628 (commit 5ad7be9c): pinned overrides!=7.6.0 in pyproject.toml to exclude the buggy upstream 7.6.0 release that broke Python plugin tests using @override on superclass methods. Same pin backported to main via #630 (694b8e96); pin later dropped in #1268.
stealth/space-bunny-alpha — closed resolved Merged #628 (5ad7be9c), excluding overrides 7.6.0 to restore Python plugin tests; #630 also merged the same pin as 694b8e96.
qwen/qwen3.6-35b-a3b — — Merged a dependency pin to exclude overrides version 7.6.0, which introduced a bug breaking Python plugin tests using the override decorator. The change was approved, passed CI, and was temporarily closed and reopened to resolve a readthedocs failure.
qwen3.6-35b-a3b-mtp-q6 — — Merged to pin the overrides dependency to exclude version 7.6.0, fixing test failures from a decorator bug. The author re-opened the PR to resolve a readthedocs CI failure before merging.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#630 (confidence 95%)

    Duplicate PR merging the identical overrides!=7.6.0 pin onto main (commit 694b8e96).

  • Caused By: overrides#121 (confidence 95%)

    Upstream bug in overrides 7.6.0 that made @override fail with 'No super class method found'.

  • Superseded By: craft-parts#1268 (confidence 85%)

    Later commit a70bf95f switched from the overrides package to typing.override, removing the dependency and the need for this pin.

Related issues

Issue Project State Summary Similarity
#630 build(deps): pin overrides!=7.6.0 (#628) craft-parts merged Merged PR #630 (commit 694b8e96), cherry-picking #628's commit 5ad7be9c to exclude overrides 7.6.0 on the feature branch.
85%