← Back to issue list

Filter out overlay directories if work dir and source dir are the same

View original Github issue

Metadata

Project
craft-parts
Number
#636
Type
issue
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Fixed by merged PR canonical/craft-parts#1261 (commit 55d01a3f): local sources now exclude the overlay directory when source and work directories match.

Resolution: closed resolved

Reason: PR #1261 was merged as commit 55d01a3f. It adds the overlay directory to local-source ignore patterns when the source equals the work directory, preventing overlay internals from entering the payload.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description Overlay dirs will be added to the payload if not filtered out. ### To Reproduce TODO ### part yaml ```shell TODO ``` ### Relevant log output ```shell TODO ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/craft-parts#1261 (commit 55d01a3f): local sources now exclude the overlay directory when source and work directories match.
stealth/space-bunny-alpha — closed resolved Fixed in merged PR #1261 (commit 55d01a3f), reordering steps when organizing to overlay so overlay directories are excluded when work and source directories match.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/craft-parts#1261 (commit 55d01a3f), which reorders overlay-organizing parts to prevent overlay directories entering the payload when work and source directories match.
stealth/space-bunny-alpha — closed resolved Fixed in merged PR #1261 (55d01a3f), which reorders steps when organizing to overlay, preventing overlay directories from entering the payload when work and source directories match.
qwen/qwen3.6-35b-a3b — — Overlay directories were incorrectly included in the payload when work and source directories matched. Fixed and merged via pull request #1261 in canonical/craft-parts.
qwen/qwen3.6-35b-a3b — — Overlay directories were incorrectly added to the payload when work and source directories matched. The bug was fixed and merged in pull request #1261, closing the issue.
qwen/qwen3.6-35b-a3b — — Fixed overlay directories incorrectly added to the payload when work and source directories matched. Resolved and merged via pull request #1261.
qwen3.6-35b-a3b-mtp-q6 — — Fixed overlay directories incorrectly added to the payload when work and source directories matched. Resolved and merged in pull request #1261.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1487 Multiple parts cannot organize to the same directory in the overlay craft-parts closed Fixed by merged PR canonical/craft-parts#1586 (commit 0797420f), allowing wildcard-organized overlay directories from multiple parts to merge despite metadata differences.
72%