← Back to issue list

plugins: add python plugin

View original Github issue

Metadata

Project
craft-parts
Number
#67
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #67 (commit 2110a224, from cb95a246/4ae91142) added the Python plugin ported from Snapcraft, landing craft_parts/plugins/python_plugin.py plus tests/docs (+332 lines).

Resolution: closed resolved

Reason: The pull request itself was merged into main by maintainer cmatsuoka as merge commit 2110a224, with commits cb95a246 ('plugins: add python plugin') and 4ae91142 ('plugins: update python plugin docstrings'). The plugin class PythonPlugin is present in craft_parts/plugins/python_plugin.py in the current tree.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The python plugin ported from snapcraft. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #67 (commit 2110a224, from cb95a246/4ae91142) added the Python plugin ported from Snapcraft, landing craft_parts/plugins/python_plugin.py plus tests/docs (+332 lines).
stealth/space-bunny-alpha — closed resolved Merged PR #67 (commit 2110a224) added a Python plugin ported from Snapcraft, introducing 332 lines across five files.
stealth/space-bunny-alpha — closed resolved Merged #67 (cb95a246, merge 2110a224), adding a Python plugin ported from Snapcraft with 332 lines across five files.
qwen/qwen3.6-35b-a3b — — Merged a Python plugin ported from snapcraft. Approved by two reviewers, passed CI, and added 332 lines across five files to extend plugin support.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#389 (confidence 70%)

    Later PR refactoring the python plugin for subclassing, building on the code merged in #67

  • Related To: craft-parts#819 (confidence 55%)

    Extracted a shared base Python plugin (#819) from the original plugin introduced here

  • Related To: canonical/snapcraft (confidence 45%)

    Source of the ported python_plugin code

  • Related To: craft-parts#1264 (confidence 40%)

    Adds a newer usrmerge-ready Python v2 plugin (craft_parts/plugins/python_v2/), evolving the plugin from #67

Related issues

Issue Project State Summary Similarity
#4044 plugins: add snapcraft python plugin snapcraft merged Merged PR #4044 (commit 302e58eeb, CRAFT-1630) added a Snapcraft-specific Python plugin subclassing Craft-parts' plugin to set venv symlinks per runtime environment.
80%
#448 docs: add python and rust plugin ref rockcraft merged Merged #448 as commit 97b692ce, adding Python and Rust plugin references ported unchanged from craft-parts and resolving #434.
73%
#1544 plugins: add the ruby plugin snapcraft merged Merged #1544, adding Snapcraft's Ruby plugin and unit tests in commits 4f87398b0 and 1f28e8ece.
72%
#2362 python plugin: add support for bases snapcraft merged Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread.
71%
#198 plugins: rust craft-parts merged Merged PR #198 (bb92a132) ported Snapcraft’s Rust plugin into craft-parts for CRAFT-955 after prerequisite test refactor #199.
71%