← Back to issue list

Plugins not verifying required part properties

View original Github issue

Metadata

Project
craft-parts
Number
#70
Type
issue
State
closed
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Fixed in PR #71. Plugins now verify required part properties like source by declaring them as pydantic fields, ensuring proper validation during unmarshalling.

Suggested action:

No scores available.

Issue body

Plugins unmarshal their own properties, but they're not checking for the presence of required part properties such as `source`. This can be done by pydantic itself if the required property is declared as a field.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Fixed in PR #71. Plugins now verify required part properties like source by declaring them as pydantic fields, ensuring proper validation during unmarshalling.
qwen/qwen3.6-35b-a3b Plugins lacked validation for required part properties. The issue was resolved by enforcing Pydantic field declarations. The fix was merged in PR #71.
qwen/qwen3.6-35b-a3b Plugins failed to verify required part properties such as source. Resolution involved enforcing field validation via Pydantic. Fixed and closed via PR #71.
qwen3.6-35b-a3b-mtp-q6 Plugins failed to verify required part properties like source. The problem was resolved by leveraging pydantic for field validation, with the fix merged in PR 71.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#71 plugins: check presence of required part properties (CRAFT-74) craft-parts merged Merged after two approvals and passing CI. Replaces manual verification of required plugin properties, such as source, with Pydantic validation. Updated nine files (+78/-25 lines) to enforce property requirements during plugin configuration.
76%