← Back to issue list

fix(part_handler): fetch correct target stage packages

View original Github issue

Metadata

Project
craft-parts
Number
#721
Type
pull request
State
open
Author
dilyn-corner
Labels
—
Created
Updated
Closed
—

Current evaluation

Fixes cross-compilation stage-package fetching to use target architecture. Approved with 1 unresolved review comment; regression testing requested but not yet confirmed.

Suggested action: needs review

Reason: The PR has 1 approval but 1 unresolved review comment from lengau requesting regression testing against LP #1983009 before merging. Recent activity (4 days ago) shows ongoing engagement, but the unresolved comment and missing regression test confirmation need addressing before the PR can be merged.

Impact: 65 Quick Win: 29.25 Staleness: 35 Complexity: 55 Confidence: 70

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This is a partial attempt at fixing https://github.com/canonical/snapcraft/issues/4542 specifically [Alex's comment](https://github.com/canonical/snapcraft/issues/4542#issuecomment-1934943478). Note that this change does not take into consideration cases where the stage package is only available for `architecture: all`.

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 65
Quick Win: 29.25
Staleness: 35
Complexity: 55
Confidence: 70
needs review Fixes cross-compilation stage-package fetching to use target architecture. Approved with 1 unresolved review comment; regression testing requested but not yet confirmed.
qwen/qwen3.8-27b
Impact: 55
Quick Win: 35.75
Staleness: 85
Complexity: 35
Confidence: 72
needs review Fixes cross-compilation stage-packages fetching by using target arch instead of host arch in part_handler. Approved by 1 reviewer but inactive for ~2 years; related snapcraft issue #4542 closed with root cause tracked in craft-parts.
qwen/qwen3.6-35b-a3b
Staleness: 92
Complexity: 15
Confidence: 85
close stale Small fix to fetch correct target stage packages. Approved by one reviewer but inactive for over 1.8 years. Maintainers requested regression testing and additional context before merging.
qwen3.6-35b-a3b-mtp-q6
Staleness: 88
Complexity: 50
Confidence: 85
close stale Addresses incorrect target stage package fetching in part_handler. Currently incomplete, lacks architecture: all support, and has been inactive since July 2024 with unresolved maintainer requests for regression testing.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 40
Confidence: 85
close stale Fixes part handler to fetch correct target stage packages for snapcraft issue 4542. Omits architecture all handling. Inactive for 160 days, pending maintainer review and regression testing against launchpad bug 1983009 before merge.

Update history

Date Change
updated

Related work

  • Related To: canonical/snapcraft#4542 (confidence 90%)

    This PR is a partial fix for the cross-compilation stage-packages issue described in snapcraft#4542

  • Related To: canonical/craft-parts#258 (confidence 85%)

    Related PR that was merged to address host-architecture repo fetching; this PR appears to be a follow-up for target architecture

  • Related To: canonical/craft-archives#104 (confidence 75%)

    Referenced by mr-cal as related to archive metadata issues affecting this fix

Related issues

Issue Project State Summary Similarity
#258 packages: fetch stage-packages from host arch's repo craft-parts merged Merged to resolve cross-compilation failures by fetching stage-packages from the host architecture repository. Approved, passed CI, and closes LP #1983009 and CRAFT-1216.
72%