packages: add test to ensure unnecessary normalize not called (CRAFT-221)
Metadata
Current evaluation
Merged in canonical/craft-parts#81 (1c9dd125), adding a regression test verifying normalization is skipped when stage-package unpacking extracts no files.
Resolution: closed resolved
Reason: PR #81 was merged as commit 1c9dd125, with commit b0dfda48 adding the CRAFT-221 regression test. It follows the normalization behavior introduced by #76.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When unpacking stage packages, it's not necessary to normalize unpacked
files if nothing was unpacked. This test verifies if no such call is
made in this case.
This is a follow-up to PR #76, and adds the normalization call test included in
https://github.com/snapcore/snapcraft/pull/3534.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-parts#81 (1c9dd125), adding a regression test verifying normalization is skipped when stage-package unpacking extracts no files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #81 via commit 1c9dd125, adding a regression test that verifies normalization is skipped when stage-package unpacking extracts no files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-parts#81 (1c9dd125), adding a regression test verifying normalization is skipped when stage-package unpacking extracts no files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a test ensuring file normalization is skipped when no files are unpacked during stage package processing. Approved by two reviewers, passed CI, and addresses CRAFT-221. Follows up on PR #76 to eliminate unnecessary processing overhead. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a test ensuring the normalize function is skipped during stage package unpacking when no files are extracted. Follows PR #76 and incorporates verification from snapcraft PR #3534 to prevent unnecessary operations. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-parts#76
(confidence 100%)
Earlier merged PR that added normalization for unpacked stage packages; #81 adds regression coverage for skipping unnecessary normalization.
-
Related To:
snapcore/snapcraft#3534
(confidence 100%)
Upstream change referenced in the PR body as the source of this regression test.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #76 packages: normalize unpacked stage packages (CRAFT-33) | craft-parts | merged | Merged PR #76 (commit 486bc6b9) added craft_parts/packages/normalize.py, porting Snapcraft package normalization: shebang rewriting, relative symlinks, suid/gid cleanup, and pkg-config/xml2/xslt path fixes. | |
| #3529 repo: normalize if stage-packages and check types (CRAFT-222) | snapcraft | merged | Merged in #3529 as commit 58d50bf, fixing stage-packages normalization to check file types so directories such as snap.pc are not passed to fileinput. |