maven plugin should install maven build-package
Metadata
Current evaluation
Maven plugin requires mvn pre-installed; reporter wants build-packages auto-added. Maintainers triaged (CRAFT-3257) and discussed making it behave like rust plugin. A self-contained build attribute was later added to maven/gradle plugins, partially addressing the need.
Suggested action: keep open
Reason: Maintainer tigarmo explicitly triaged this as intentional design and lengau proposed changing it to behave like the rust plugin (auto-install system maven when no maven-deps part exists), with an internal ticket CRAFT-3257 created. The maven plugin still returns an empty get_build_packages() set, so the core request (auto-install maven/jdk) is not implemented in craft-parts; the later self-contained build attribute only addresses dependency mirroring, not the missing mvn binary. This is a valid, acknowledged feature request that remains unaddressed.
Impact:
50
Quick Win:
27.5
Staleness:
55
Complexity:
45
Confidence:
60
Support Request:
25
Issue body
### Bug Description
maven plugin does not install maven build-package.
In order to use maven plugin the image should have maven installed already which is inconvenient.
Would it be possible to append
```
build-packages:
- maven
- openjdk-21-jdk-headless
```
if the part does not contain 'build-packages'
### To Reproduce
1. create a rockcraft application with a maven part.
2. rockcraft pack
### part yaml
```shell
application:
plugin: maven
source: sample
source-type: local
```
### Relevant log output
```shell
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.441 plugin validation command: 'mvn --version'
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.443 Environment validation failed for part 'application': 'mvn' not found and part 'application' does not depend on a part named 'maven-deps' that would satisfy the dependency.
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 Traceback (most recent call last):
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_parts/plugins/validator.py", line 101, in validate_dependency
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 output = self._execute(command).strip()
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_parts/plugins/validator.py", line 145, in _execute
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 proc = subprocess.run(
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 File "/snap/rockcraft/2374/usr/lib/python3.10/subprocess.py", line 526, in run
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 raise CalledProcessError(retcode, process.args,
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 subprocess.CalledProcessError: Command '['/bin/bash', '/tmp/tmpx0rd72pf']' returned non-zero exit status 127.
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 The above exception was the direct cause of the following exception:
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 Traceback (most recent call last):
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_application/services/lifecycle.py", line 256, in run
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 with self._lcm.action_executor() as aex:
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_parts/executor/executor.py", line 304, in __enter__
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 self._executor.prologue()
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_parts/executor/executor.py", line 91, in prologue
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 self._verify_plugin_environment()
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.444 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_parts/executor/executor.py", line 290, in _verify_plugin_environment
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.445 validator.validate_environment(part_dependencies=part.dependencies)
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.445 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_parts/plugins/maven_plugin.py", line 64, in validate_environment
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.445 version = self.validate_dependency(
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.445 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_parts/plugins/validator.py", line 118, in validate_dependency
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.445 raise errors.PluginEnvironmentValidationError(
2024-08-16 11:32:31.728 :: 2024-08-16 11:32:31.445 craft_parts.errors.PluginEnvironmentValidationError: Environment validation failed for part 'application': 'mvn' not found and part 'application' does not depend on a part named 'maven-deps' that would satisfy the dependency.
2024-08-16 11:32:31.729 Executing on host: lxc --project rockcraft config device show local:rockcraft-maven-sample-chisel-on-amd64-for-amd64-61079577
2024-08-16 11:32:31.820 Executing on host: lxc --project rockcraft config device remove local:rockcraft-maven-sample-chisel-on-amd64-for-amd64-61079577 disk-/root/project
2024-08-16 11:32:31.954 Executing on host: lxc --project rockcraft stop local:rockcraft-maven-sample-chisel-on-amd64-for-amd64-61079577
2024-08-16 11:32:35.883 Failed to execute rockcraft in instance.
2024-08-16 11:32:35.885 Traceback (most recent call last):
2024-08-16 11:32:35.885 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_application/application.py", line 376, in run_managed
2024-08-16 11:32:35.885 instance.execute_run( # pyright: ignore[reportUnknownMemberType,reportUnknownVariableType]
2024-08-16 11:32:35.885 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_providers/lxd/lxd_instance.py", line 293, in execute_run
2024-08-16 11:32:35.885 return self.lxc.exec(
2024-08-16 11:32:35.885 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_providers/lxd/lxc.py", line 387, in exec
2024-08-16 11:32:35.885 return runner(final_cmd, timeout=timeout, check=check, **kwargs)
2024-08-16 11:32:35.885 File "/snap/rockcraft/2374/usr/lib/python3.10/subprocess.py", line 526, in run
2024-08-16 11:32:35.885 raise CalledProcessError(retcode, process.args,
2024-08-16 11:32:35.885 subprocess.CalledProcessError: Command '['lxc', '--project', 'rockcraft', 'exec', 'local:rockcraft-maven-sample-chisel-on-amd64-for-amd64-61079577', '--cwd', '/root/project', '--', 'env', 'CRAFT_MANAGED_MODE=1', 'DEBIAN_FRONTEND=noninteractive', 'DEBCONF_NONINTERACTIVE_SEEN=true', 'DEBIAN_PRIORITY=critical', 'CRAFT_PLATFORM=amd64', 'CRAFT_VERBOSITY_LEVEL=BRIEF', 'rockcraft', 'pack']' returned non-zero exit status 1.
2024-08-16 11:32:35.885
2024-08-16 11:32:35.885 The above exception was the direct cause of the following exception:
2024-08-16 11:32:35.885 Traceback (most recent call last):
2024-08-16 11:32:35.885 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_application/application.py", line 541, in run
2024-08-16 11:32:35.885 self.run_managed(platform, build_for)
2024-08-16 11:32:35.885 File "/snap/rockcraft/2374/lib/python3.10/site-packages/craft_application/application.py", line 383, in run_managed
2024-08-16 11:32:35.885 raise craft_providers.ProviderError(
2024-08-16 11:32:35.885 craft_providers.errors.ProviderError: Failed to execute rockcraft in instance.
2024-08-16 11:32:35.885 Full execution log: '/home/vladimirp/.local/state/rockcraft/log/rockcraft-20240816-113034.715917.log'
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.8-27b |
Impact:
50
Quick Win:
27.5
Staleness:
55
Complexity:
45
Confidence:
60
Support Request:
25
|
keep open | Maven plugin requires mvn pre-installed; reporter wants build-packages auto-added. Maintainers triaged (CRAFT-3257) and discussed making it behave like rust plugin. A self-contained build attribute was later added to maven/gradle plugins, partially addressing the need. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
85
Complexity:
30
Confidence:
75
Support Request:
20
|
close stale | Maven plugin requires manual build-packages for maven/JDK. Reporter suggests auto-installing them. Open for over a year with no maintainer labels, assignment, or implementation progress. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
30
Confidence:
80
Support Request:
15
|
close stale | Untriaged feature request to auto-install maven and JDK build packages. Inactive for over a year with no maintainer response or implementation. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
75
Complexity:
25
Confidence:
75
Support Request:
10
|
keep open | Auto-install maven and JDK build-packages in the maven plugin when not explicitly defined. Open. Contributors suggest mimicking the rust plugin or implementing a rockcraft-only override. Awaiting implementation decision. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-parts#1145
(confidence 55%)
Adds self-contained build attribute for Maven plugins, related to making maven builds more self-sufficient but does not auto-install mvn.
Related issues
No related issues found above the similarity threshold.