← Back to issue list

fix(plugins): ensure stateless npm plugin

View original Github issue

Metadata

Project
craft-parts
Number
#845
Type
pull request
State
merged
Author
liushuyu
Labels
—
Created
Updated
Closed

Current evaluation

Merged #845 as fab2ecc1, making the npm plugin stateless so Launchpad pull and build steps no longer lose shared state; temporary 1.33-branch fix for #844.

Resolution: closed resolved

Reason: The approved PR was merged as commit fab2ecc1. A maintainer confirmed that the linked #844 Launchpad repro builds locally with the change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- This pull request works around an issue that regressed NPM-based projects on the Launchpad auto-build system. The issue was that the Launchpad auto-build system executed pull and build steps separately, thereby losing the shared state between them. This is a temporary fix for the 1.33 branch.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #845 as fab2ecc1, making the npm plugin stateless so Launchpad pull and build steps no longer lose shared state; temporary 1.33-branch fix for #844.
stealth/space-bunny-alpha — closed resolved Merged PR #845 made the npm plugin stateless, fixing separate Launchpad pull/build steps that lost shared state. The temporary fix targeted the 1.33 branch and resolved #844.
qwen/qwen3.6-35b-a3b — — Merged to the 1.33 branch. Resolves a regression where separate Launchpad auto-build steps lost shared state by ensuring the npm plugin operates statelessly. Approved by three reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged a temporary fix for the 1.33 branch resolving NPM plugin state loss during separate pull and build steps in the Launchpad auto-build system. Confirmed working locally.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#844 (confidence 100%)

    Launchpad npm plugin failure caused by separate pull and build steps losing shared state; fixed by #845.

Related issues

Issue Project State Summary Similarity
#844 npm plugin fails on launchpad craft-parts closed Fixed in canonical/craft-parts#845 (commit fab2ecc1) by making npm plugin setup stateless, restoring npm for Launchpad override-builds.
78%