← Back to issue list

Removed files from local sources remain in the part

View original Github issue

Metadata

Project
craft-parts
Number
#851
Type
issue
State
open
Author
lengau
Labels
Status: Triaged Type: Bug
Created
Updated
Closed
—

Current evaluation

Bug: files deleted from a local source directory are not removed from the part's src directory on a second pull. Triaged; a maintainer provided a reproducer branch and failing unit test, awaiting implementation. Bug still present in current code.

Suggested action: keep open

Reason: The issue is triaged (Status: Triaged, Type: Bug labels) and a maintainer recently (97 days ago) posted a reproducer branch 'repro/851-local-source-deleted-files' with a failing test 'test_pulling_twice_removes_deleted_source_files' that was validated to fail pre-fix, so it is actively being worked toward a fix. I confirmed in craft_parts/sources/local_source.py that pull() and update() still have no deleted-file handling, so the bug remains unfixed and the issue should stay open.

Impact: 50 Quick Win: 27.5 Staleness: 35 Complexity: 45 Confidence: 85 Support Request: 0

Issue body

### Bug Description See: https://github.com/canonical/charmcraft/issues/710 Deleting a file from a local source doesn't remove it from the part's `src` directory ### To Reproduce See: https://github.com/canonical/charmcraft/issues/710 ### part yaml ```shell parts: data: plugin: dump source: . ``` ### Relevant log output ```shell n/a ```

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 50
Quick Win: 27.5
Staleness: 35
Complexity: 45
Confidence: 85
Support Request: 0
keep open Bug: files deleted from a local source directory are not removed from the part's src directory on a second pull. Triaged; a maintainer provided a reproducer branch and failing unit test, awaiting implementation. Bug still present in current code.
qwen/qwen3.6-35b-a3b
Staleness: 45
Complexity: 35
Confidence: 90
Support Request: 0
keep open Bug where deleting files from a local source directory does not remove them from the part's src directory after a second pull. Triaged, with a maintainer-provided reproducer and failing test waiting for implementation.
qwen3.6-35b-a3b-mtp-q6
Staleness: 15
Complexity: 40
Confidence: 90
Support Request: 5
keep open Bug where deleting files from a local source directory does not remove them from the part's build directory during subsequent pulls. Currently triaged, with a maintainer-provided reproducer branch and failing test awaiting implementation.
qwen3.6-35b-a3b-mtp-q6
Staleness: 35
Complexity: 25
Confidence: 90
Support Request: 5
keep open Bug where deleting files from a local source does not remove them from the part's src directory on subsequent pulls. Triaged, includes a reproducer branch and failing test, awaiting implementation.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#710 (confidence 90%)

    Original upstream report this issue explicitly references for the bug description and reproduction.

  • Related To: craft-parts#105 (confidence 80%)

    Earlier attempt 'sources: verify deleted files in outdated check' (commit 5d56713d) addressing the same deleted-file problem.

  • Related To: craft-parts#132 (confidence 80%)

    Reverted the earlier deleted-files fix (commit 5e5cb6c6), explaining why the bug persists and why the fix is non-trivial.

Related issues

No related issues found above the similarity threshold.