fix(poetry): don't install poetry with poetry-deps
Metadata
Current evaluation
PR #901 merged as commit 2eda2a5a: the Poetry plugin skips adding python3-poetry (and the export plugin) to build packages when a poetry-deps part supplies them. Fixes charmcraft#1996 (CRAFT-3687); noted in the 2.34.1 changelog.
Resolution: closed resolved
Reason: The PR itself was merged (approved by 2 reviewers, 0 unresolved comments) as commit 2eda2a5a. craft_parts/plugins/poetry_plugin.py now guards build-package installation on "poetry-deps" not being in part dependencies, with unit tests in tests/unit/plugins/test_poetry_plugin.py and a changelog entry under 2.34.1.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If a `poetry-deps` dependent part exists, don't add poetry to the packages to install.
Fixes https://github.com/canonical/charmcraft/issues/1996
CRAFT-3687
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #901 merged as commit 2eda2a5a: the Poetry plugin skips adding python3-poetry (and the export plugin) to build packages when a poetry-deps part supplies them. Fixes charmcraft#1996 (CRAFT-3687); noted in the 2.34.1 changelog. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-parts PR #901 as commit 2eda2a5a, skipping Poetry installation when a poetry-deps part already supplies it; fixes charmcraft#1996 (CRAFT-3687). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix preventing poetry installation when a poetry-deps part exists, resolving issue #1996. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix preventing poetry from being installed when a poetry-deps dependent part exists. Resolves issue #1996 and CRAFT-3687 by conditionally excluding poetry from the package list. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#1996
(confidence 95%)
Downstream bug the PR body cites as 'Fixes'; closed after this upstream change.
-
Related To:
canonical/craft-parts#1633
(confidence 80%)
Later PR refining the same export-plugin install logic in the Poetry plugin.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1633 fix(poetry): don't install the export plugin from apt | craft-parts | merged | Merged #1633 in commit fbe33c05: Poetry now installs the export plugin only when Poetry itself was not installed from apt. | |
| #1492 Fix poetry plugin for 25.04+ | craft-parts | closed | Craft-parts fixed Poetry 2 export compatibility by conditionally installing python3-poetry-plugin-export on Ubuntu 25.04+ in PR #1510 (commit 6d30ef14). | |
| #1996 Poetry plugin fails on 20.04 base | charmcraft | closed | Poetry plugin added python3-poetry-plugin-export to apt build-packages, unavailable on Ubuntu 20.04. Fixed upstream in craft-parts PR #1633 (commit cff4121b/fbe33c05); issue closed after upstream fix. | |
| #1510 fix(poetry): install export plugin on 25.04+ | craft-parts | merged | Merged PR #1510 in commit 6d30ef14, adding python3-poetry-plugin-export on Ubuntu 25.04+ to preserve Poetry's export functionality. | |
| #820 feat(plugin): add poetry plugin | craft-parts | merged | Merged Poetry plugin support in commit 8b0d76c8, adding first-class build-system handling via poetry install and resolving #707. | |
| #2053 docs: fix poetry-with description | charmcraft | merged | Merged into main via charmcraft#2053 (commit 455880a4), clarifying that Poetry's --with is required for optional and non-optional dependencies. | |
| #1940 feat(docs): add python and poetry plugin docs | charmcraft | merged | PR #1940 merged as commit 408650c8, adding Python and Poetry plugin documentation (+144 lines, 6 files). Builds on #1939 (craft-parts common docs) and required craft-parts#872 anchors; merged despite12 unresolved review comments. | |
| #2629 build(deps-dev): bump poetry from 2.3.2 to 2.3.3 | charmcraft | closed | Dependabot bump of dev dependency poetry 2.3.2→2.3.3 was closed unmerged by lengau as a duplicate of #2624, which already applied the same poetry security update to main (commit 5b858d29; also #2628 on hotfix/4.2, 36f30ad6). | |
| #18 Poetry integration | charmcraft | closed | Poetry support was ultimately delivered as Charmcraft-specific python/poetry craft-parts plugins, added in PR #1899 (commit 8b748f3e, 2023), superseding the older build.py requirements.txt idea; issue closed once shipped. | |
| #1873 Create charmcraft-specific versions of the upstream `python` and `poetry` plugins | charmcraft | closed | Charmcraft-specific Python and Poetry plugins were added by merged PR #1899 (commit 8b748f3e), replacing the experimental work in #1840. |