← Back to issue list

fix: correct package versioning error

View original Github issue

Metadata

Project
craft-parts
Number
#957
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged fix for package versioning error. Removed invalid single quotes from the git_describe_command array that caused shell expansion failures and incorrect version detection. Approved by two reviewers and merged.

Suggested action: —

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ----- 690fe318e346446ba9948da652d38702e7e2bc7b broke the versioning command and caused `@ git+` downloads of this repository to get versioned as `0.0`. The default `git_describe_command` is an array, and the schema requires it to be an array, but it was previously a string anyways. The broken commit attempted to correct this, but it appears that the `git_describe_command` variable is passed directly to something unaware of shell expansions. This meant that the arguments `'[0-9]*.[0-9]*.[0-9]*'` and `'*[^0-9.]*'` were invalid as the `*`s were fine but the `'`s only confused it. This PR removes those ticks. Confirmed to correctly publish the version number with both `uv build` and `python3 -m build`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged fix for package versioning error. Removed invalid single quotes from the git_describe_command array that caused shell expansion failures and incorrect version detection. Approved by two reviewers and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for a package versioning error. Removed single quotes from git_describe_command arguments that broke version detection, restoring correct version output during builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#288 fix: use correct package for version craft-application merged Merged a one-line fix to correct the package used for versioning. Approved by two reviewers and passed CI checks.
81%