← Back to issue list

fix(tests): don't fail if you have additional JREs

View original Github issue

Metadata

Project
craft-parts
Number
#986
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged a fix preventing test failures when additional JREs are installed. Approved by two reviewers, passed CI, and modified one file with two line changes. Resolves #985.

Suggested action: —

No scores available.

Issue body

Fixes #985 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a fix preventing test failures when additional JREs are installed. Approved by two reviewers, passed CI, and modified one file with two line changes. Resolves #985.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that prevents test failures when multiple JREs are installed. Resolves issue #985 by updating test logic to accommodate additional Java runtime environments without triggering false negatives.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#278 tests: additional tests to improve coverage fetch-service merged Merged after two reviews and passing CI checks. Adds additional tests across ten files to improve code coverage, changing +386/-60 lines.
74%
#461 test: improve test coverage fetch-service merged Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing.
73%
#1928 tests: remove duplicate tests snapcraft merged Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
73%
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
72%
#3305 unit tests: fix runtests.sh not filtering tests when passed a subdirectory snapcraft merged Merged a one-line fix correcting runtests.sh to properly filter tests when a subdirectory is passed. Previously, the script ran the entire suite. Approved by two reviewers, passed CI, and merged.
72%
#896 test: don't leave behind test files rockcraft merged Merged a fix preventing OCI tests from leaving residual files in the project root. The change redirects test output to a temporary directory. Approved by three reviewers with all CI checks passing.
71%
#458 test: improve test coverage fetch-service merged Merged after approval from two reviewers and passing CI checks. Added 370 lines of test code across five files to improve overall test coverage.
71%
#563 fix(tests): replace ineffective call assertions craft-parts merged Merged to main, resolving issue #368 by replacing ineffective assert_has_calls with assert mock_calls in packages.deb module tests. Approved by two reviewers, passed CI, and rebased before final merge.
70%
#117 a couple of fixes for tests charmcraft merged Merged to resolve issue #105. Approved by two reviewers, the pull request implements minor test corrections across two files with a +10/-1 line change.
70%
#433 fix(tests): better typing for tests starbase merged Merged improvements to test type annotations to satisfy the ty type checker. Approved by two reviewers, passed all CI checks, and applied with a minimal +7/-6 line change across one file.
70%