← Back to issue list

fix(tests): don't fail if you have additional JREs

View original Github issue

Metadata

Project
craft-parts
Number
#986
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #986 as 50af1b91 (change d36a93d5), updating Java plugin tests to tolerate additional installed JREs and fixing #985.

Resolution: closed resolved

Reason: PR #986 was approved and merged into the main branch, resolving #985. Commit d36a93d5 changes the Java plugin test setup so unexpected installed JREs no longer cause failures.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #985 - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #986 as 50af1b91 (change d36a93d5), updating Java plugin tests to tolerate additional installed JREs and fixing #985.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-parts#986 (50af1b91), fixing Java plugin tests so installed JREs do not cause failures; resolves #985.
qwen/qwen3.6-35b-a3b — — Merged a fix preventing test failures when additional JREs are installed. Approved by two reviewers, passed CI, and modified one file with two line changes. Resolves #985.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix that prevents test failures when multiple JREs are installed. Resolves issue #985 by updating test logic to accommodate additional Java runtime environments without triggering false negatives.

Update history

No update history recorded yet.

Related work

  • Related To: craft-parts#985 (confidence 100%)

    The linked Java plugin test failure was explicitly fixed by PR #986.

Related issues

Issue Project State Summary Similarity
#985 Java plugin tests fail if you have a JDK newer than 17 but != 21 craft-parts closed Fixed by merged PR #986 (commit d36a93d5, 'fix(tests): don't fail if you have additional JREs'), making Java plugin tests tolerate extra installed JDKs like 25 instead of asserting JAVA_HOME.
80%