← Back to issue list

feat: add EFI arch abbreviation translation (#53)

View original Github issue

Metadata

Project
craft-platforms
Number
#153
Type
pull request
State
merged
Author
steinbro
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #153 (commit 973af31) added to_efi_arch() and to_grub_arch() to DebianArchitecture, with separate EFI and GRUB translation dicts in _architectures.py, plus unit tests. Closes issue #53.

Resolution: closed resolved

Reason: The PR itself was merged as commit 973af31 ("feat: add EFI arch abbreviation translation (#53) (#153)"), which added DebianArchitecture.to_efi_arch() and to_grub_arch() backed by _ARCH_TRANSLATIONS_DEB_TO_EFI and _ARCH_TRANSLATIONS_DEB_TO_GRUB in craft_platforms/_architectures.py, with tests in tests/unit/test_architectures.py. It implements the enhancement tracked in issue #53, which is now closed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Need to confirm: 1. What is the exhaustive set of EFI architecture abbreviations? The list at https://github.com/systemd/systemd/blob/main/src/ukify/ukify.py doesn't include all deb platforms, e.g. `armhf`. 2. Does this translation functionality need to be exposed anywhere, besides a couple new methods on `DebianArchitecture`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #153 (commit 973af31) added to_efi_arch() and to_grub_arch() to DebianArchitecture, with separate EFI and GRUB translation dicts in _architectures.py, plus unit tests. Closes issue #53.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #53 adds EFI architecture abbreviation translation to `DebianArchitecture`, separating EFI and GRUB lists into a unified dict.

Update history

Date Change
created

Related work

  • Related To: craft-platforms#53 (confidence 98%)

    Upstream enhancement issue 'Add EFI architectures and a way to convert between deb arches and EFI arches'; the PR title references (#53) and the feature implements it, with the issue now closed.

  • Related To: craft-platforms#167 (confidence 55%)

    Later style-only follow-up touching the same file (docstring line breaks in _architectures.py), not a functional change to this feature.

  • Related To: craft-platforms#244 (confidence 50%)

    Later fix adding armv8l platform-arch support in the same file; the EFI/GRUB mappings added here remain unchanged by it.

Related issues

Issue Project State Summary Similarity
#53 Add EFI architectures and a way to convert between deb arches and EFI arches craft-platforms closed Fixed by merged PR #153 (commit 973af31), adding Debian-to-EFI architecture mappings, to_efi_arch() conversion, and unit tests.
80%