## Summary Fixed platform name parsing issue where names containing colons (e.g., "0:") were incorrectly treated as having a base prefix, causing ValueError. ## Changes Made - [x] Understand the issue: Platform name "0:" incorrectly treated as base string - [x] Add test case for platform name "0:" in test_platforms.py - [x] Fix parse_base_and_name to only treat prefix as base if it contains "@" - [x] Add test case for charm build plan with "0:" platform - [x] Run tests to verify the fix (8801 tests pass) - [x] Run linters to ensure code quality (ruff, mypy) - [x] Code review passed with no issues - [x] Security scan passed with no vulnerabilities - [x] Address review feedback: Fix docstring typo ## Key Change Updated `parse_base_and_name()` to check if the prefix before ":" contains "@" before treating it as a base string. This allows platform names like "0:" to be treated as valid platform names rather than invalid base specifications. ## Testing - All 8801 unit tests pass - Verified exact scenario from issue works correctly - Tested edge cases (numbers, text, mixed formats) - Code quality checks pass (ruff formatting and linting, mypy) - Security scan clean ## Security Summary No vulnerabilities were discovered during the security scan. <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Charm with weird platform name breaks</issue_title> > <issue_description>A charm with: > > ```yaml > base: ubuntu@24.04 > platforms: > "0:": > build-on: [amd64] > build-for: [amd64] > ``` > > Raises `ValueError: Invalid base string '0'. Format should be '<distribution>@<series>'`. > > First discovered at https://github.com/canonical/craft-platforms/actions/runs/14137328500/job/39612051861?pr=83#step:6:205</issue_description> > > <agent_instructions>Start by writing a test matching the error case. Then write a fix.</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes canonical/craft-platforms#116 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/canonical/craft-platforms/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.