fix(docs): remove dead sphinx-toolbox.github config
Metadata
Current evaluation
Closed unmerged as superseded by #275; its removal of dead sphinx-toolbox GitHub settings landed in 75dff07 and reached main through merged #270 (4afcee7).
Resolution: closed superseded
Reason: PR #274 was closed because #275 performed the same four-line docs/conf.py cleanup. Commit 75dff07 contains the removal, and the work reached main through merged PR #270 at commit 4afcee7.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`#271` removed the `sphinx_toolbox` extension from `docs/conf.py`'s `extensions` list (and the Makefile workaround for it), but left its `github.*` config options (`github_username`, `github_repository`) behind. These are unused now that the extension reading them is gone.
Spotted during review of #270: https://github.com/canonical/craft-platforms/pull/270#discussion_r4074584296
🤖 [BEEP BOOP, A BOT WROTE THIS COMMENT - Claude Sonnet 5, GitHub Copilot CLI]
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged as superseded by #275; its removal of dead sphinx-toolbox GitHub settings landed in 75dff07 and reached main through merged #270 (4afcee7). | |
| stealth/space-bunny-alpha | — | closed superseded | Cleanup landed in follow-up #275 (commit 75dff07), removing obsolete sphinx-toolbox GitHub settings left after #271; #274 was closed as superseded. | |
| qwen/qwen3.6-35b-a3b |
Impact:
10
Quick Win:
8
Complexity:
5
Confidence:
85
Actionability:
80
|
needs review | Removes unused github_username and github_repository config options from docs/conf.py left over after sphinx-toolbox extension removal. CI passing, awaiting review. |
Update history
| Date | Change |
|---|---|
| closed | |
| created |
Related work
-
Caused By:
canonical/craft-platforms#271
(confidence 99%)
Removed the sphinx_toolbox extension but left its github_username and github_repository settings behind.
-
Superseded By:
canonical/craft-platforms#275
(confidence 98%)
Its commit 75dff07 removed the obsolete sphinx-toolbox GitHub configuration targeted by #274.
-
Related To:
canonical/craft-platforms#270
(confidence 95%)
Merged as commit 4afcee7 and incorporated the #275 branch containing the cleanup.
Related issues
No related issues found above the similarity threshold.