← Back to issue list

Replace Python 3.10 workaround for enum value checking

View original Github issue

Metadata

Project
craft-platforms
Number
#296
Type
pull request
State
open
Author
Tusharkanda
Labels
—
Created
Updated
Closed
—

Current evaluation

No evaluation has been recorded for this issue yet.

Issue body

Replaces the `try/except ValueError` workaround in `_platforms.py` for checking whether a platform name is a valid Debian architecture with a direct membership check against the enum's values (`platform_name not in (arch.value for arch in DebianArchitecture)`). This works on Python 3.8+, so it no longer needs to wait for the Python 3.12 `in` behavior the old comment referenced, and makes the validation intent explicit instead of relying on exception-driven control flow. Pure refactor — no behavior change. Fixes #233

Evaluation history

No evaluation history available.

Update history

Date Change
updated
created

Related issues

No embedding available for this issue yet. Run scripts/run_llm.py evaluate to enable similarity search.