← Back to issue list

fix: add snapd to literal list

View original Github issue

Metadata

Project
craft-platforms
Number
#65
Type
pull request
State
merged
Author
mattculler
Labels
—
Created
Updated
Closed

Current evaluation

PR #65 merged (merge commit d333fae) adding "snapd" to the acceptable snap types for empty bases; SNAP_TYPES_WITHOUT_BASE is now ("base", "kernel", "snapd") in craft_platforms/snap/_build.py.

Resolution: closed resolved

Reason: Maintainer mattculler's PR was approved by 2 reviewers and merged via commit d333fae (change commit f055619). The literal list in craft_platforms/snap/_build.py now includes "snapd", later reinforced by #119 which passes the snap type into build-plan generation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ----- The list of acceptable snap types for empty bases should also include "snapd".

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #65 merged (merge commit d333fae) adding "snapd" to the acceptable snap types for empty bases; SNAP_TYPES_WITHOUT_BASE is now ("base", "kernel", "snapd") in craft_platforms/snap/_build.py.
qwen/qwen3.6-35b-a3b — closed resolved Merged fix to include 'snapd' in the list of acceptable snap types for empty bases.

Update history

Date Change
created

Related work

  • Related To: canonical/craft-platforms#119 (confidence 72%)

    Follow-up commit 70d4be4 'fix: pass snap type to obtain the snapcraft build plan' built on the snap-type list introduced/updated by f055619.

  • Related To: canonical/craft-platforms#21 (confidence 35%)

    Earlier commit 5278aa0 (feat: make build plans for snaps with platforms) originated the empty-base snap-type handling that #65 amended.

Related issues

Issue Project State Summary Similarity
#137 base: add optional list of snaps to install craft-providers merged Merged PR #137, adding optional BuilddBase snap installation through a Pydantic model; merge commit fc53896.
71%
#6499 fix: parse build-base for snapcraftctl validation snapcraft merged Fixed a validator bug preventing core22/core24 snaps without a `base` key from using `snapcraftctl`. Merged as #6499, resolving #6336.
71%