← Back to issue list

chore: reduce verbosity of timer logging

View original Github issue

Metadata

Project
craft-providers
Number
#1011
Type
pull request
State
open
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Reduces timer logging verbosity and increases update interval from 3s to 30s in craft-providers. Has 3 unresolved review comments and one failing CI check.

Suggested action: needs review

Reason: The PR has 3 unresolved review comments and one failing CI check (test-basic / Slow tests on ubuntu-24.04) that need attention. It's a small, low-risk logging change addressing issue #450, but requires maintainer review to address the review comments and investigate the failing CI before merging.

Impact: 20 Quick Win: 17.0 Staleness: 25 Complexity: 15 Confidence: 60

Issue body

Don't create a log message log every time the instance timer is set, and update it less frequently (every 30 seconds instead of 3 seconds). Fixes #450 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 20
Quick Win: 17.0
Staleness: 25
Complexity: 15
Confidence: 60
needs review Reduces timer logging verbosity and increases update interval from 3s to 30s in craft-providers. Has 3 unresolved review comments and one failing CI check.

Update history

Date Change
updated
updated
created

Related work

  • Related To: craft-providers#450 (confidence 95%)

    This PR explicitly claims to fix issue #450 (Timer thread logging is overly verbose), which has been open for 1031 days.

Related issues

Issue Project State Summary Similarity
#409 chore(deps): update craft-providers to 1.19.2 rockcraft merged Merged update to craft-providers 1.19.2, fixing blocking looping timer and error log collection bugs. Approved by reviewer and passed CI.
76%
#903 chore: update craft-providers rockcraft merged The craft-providers update was merged after receiving approval from two reviewers and passing all CI checks. Changes affected two files with minor adjustments (+5/-5 lines).
75%
#1414 chore(deps): use craft-providers 1.19.3 charmcraft merged Merged dependency update to craft-providers 1.19.3, resolving cache directory deletion issues. Approved by two reviewers, passed CI checks, and integrated without unresolved comments.
73%
#1294 chore(deps): craft-providers to v1.18.0 charmcraft merged Dependency update for craft-providers to v1.18.0 was approved by two reviewers, passed CI checks, and successfully merged with minimal changes across two files.
71%
#5641 chore: test craft-providers change snapcraft closed Closed without merging due to inactivity. The PR added tests for a craft-providers change but received no reviews or comments. CI passed all checks except one integration test. The contribution was abandoned.
71%
#407 chore(deps): bump craft-providers rockcraft closed Closed to update the craft-providers dependency and resolve an account ack failure. No review comments or CI checks were recorded.
70%