← Back to issue list

chore: reduce verbosity of timer logging

View original Github issue

Metadata

Project
craft-providers
Number
#1011
Type
pull request
State
open
Author
cmatsuoka
Labels
—
Created
Updated
Closed
—

Current evaluation

Changes the LXD instance heartbeat from 3 to 30 seconds and removes per-update timer logging; one slow test is failing and three review comments remain unresolved.

Suggested action: needs review

Reason: The narrow timer cadence and logging change addresses the still-open maintainer issue #450. However, the ubuntu-24.04/3.12 slow test is failing, three review comments remain unresolved, and no reviewer has approved it; missing failure details limit confidence in immediate merge readiness.

Evaluated by: mr-cal-bot

Impact: 38 Quick Win: 14 Complexity: 16 Confidence: 88 Actionability: 45

Issue body

Don't create a log message log every time the instance timer is set, and update it less frequently (every 30 seconds instead of 3 seconds). Fixes #450 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 38
Quick Win: 14
Complexity: 16
Confidence: 88
Actionability: 45
needs review Changes the LXD instance heartbeat from 3 to 30 seconds and removes per-update timer logging; one slow test is failing and three review comments remain unresolved.
stealth/space-bunny-alpha
Impact: 32
Quick Win: 14
Complexity: 12
Confidence: 88
Actionability: 48
needs review Suppresses logs when setting the instance timer and lengthens updates from 3 to 30 seconds; awaiting review with one slow-test failure and 3 reported unresolved comments.
qwen3.6-35b-a3b-mtp-q6
Impact: 20
Quick Win: 17
Staleness: 25
Complexity: 15
Confidence: 60
needs review Reduces timer logging verbosity and increases update interval from 3s to 30s in craft-providers. Has 3 unresolved review comments and one failing CI check.

Update history

Date Change
updated
updated
created

Related work

  • Related To: canonical/craft-providers#450 (confidence 100%)

    The body explicitly says it fixes #450, which reports overly verbose 3-second timer updates.

Related issues

Issue Project State Summary Similarity
#450 Timer thread logging is overly verbose craft-providers open Maintainer-filed enhancement to quiet timer-thread output and refresh every 30 seconds instead of 5; the current LXD readiness loop still logs full status and timer details every 3 seconds.
71%