fix: include unknown Ubuntu version in compatibility warnings
Metadata
Current evaluation
Improves compatibility warnings to include unknown Ubuntu versions instead of raising errors. Has 3 unresolved review comments and no reviewers yet.
Suggested action: needs review
Reason: The PR has 3 unresolved review comments and no reviewers yet. The author has addressed Copilot review feedback but is awaiting maintainer review. The change is small (+37/-6) and focused on improving warning messages for unknown Ubuntu versions.
Evaluated by: mr-cal-bot
Impact:
40
Quick Win:
10
Complexity:
25
Confidence:
70
Actionability:
35
Issue body
## Description
Reworked per maintainer feedback: the original typed-error approach raised `BaseConfigurationError` for unknown host/guest Ubuntu versions, but warn-and-return is intentional in `ensure_guest_compatible` (compatibility is assumed when the version is unknown). Raising broke a 24.10 host building a Jammy guest and rolling DEVEL guests.
This PR keeps the graceful behavior and only improves the diagnostics: the warning now includes the unknown version (with `<unknown>` when `VERSION_ID` is missing), so the logs stay actionable.
## Changes
- `craft_providers/bases/checks.py`: include the unknown host/guest version in the compatibility warnings instead of raising.
- `tests/unit/bases/test_checks.py`: restored the graceful-handling tests; added a test that a missing host `VERSION_ID` warns with `<unknown>` and returns.
## Related Issue
Related to #969 (does not implement the typed error proposed there; see review discussion).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
40
Quick Win:
10
Complexity:
25
Confidence:
70
Actionability:
35
|
needs review | Improves compatibility warnings to include unknown Ubuntu versions instead of raising errors. Has 3 unresolved review comments and no reviewers yet. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
craft-providers#969
(confidence 85%)
Issue #969 proposed a typed error for unknown versions; this PR explicitly does not implement that approach per review discussion.
Related issues
No related issues found above the similarity threshold.