← Back to issue list

Add deterministic regression coverage for instance reuse during shutdown

View original Github issue

Metadata

Project
craft-providers
Number
#1038
Type
pull request
State
open
Author
copilot-swe-agent
Labels
—
Created
Updated
Closed
—

Current evaluation

Test-only regression coverage for LXD instance reuse mid-shutdown race (issue #1037). Test intentionally fails until shutdown recovery is implemented. 43 lines added, 0 reviewers, CI passing.

Suggested action: needs review

Reason: Clean test-only addition (+43/-0) that documents the race condition from issue #1037. The PR is 0 days old with no reviewers and the test intentionally fails until the actual shutdown recovery fix is implemented. Needs maintainer review to confirm the test approach is acceptable and to coordinate with the eventual fix.

Evaluated by: mr-cal-bot

Impact: 25 Quick Win: 13 Complexity: 15 Confidence: 75 Actionability: 60

Issue body

Reusing an LXD instance mid-shutdown can silently ignore a failed `shutdown -c`, allowing `start()` to return successfully before subsequent commands fail because the instance has stopped. - **Regression coverage** - Model cancellation rejection and completed shutdown synchronously, without guest timing or a live LXD daemon. - Assert that reuse leaves the instance running. - **Scope** - Test-only change; production behavior remains unchanged. - The regression intentionally fails until shutdown recovery is implemented. <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes #1037

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 25
Quick Win: 13
Complexity: 15
Confidence: 75
Actionability: 60
needs review Test-only regression coverage for LXD instance reuse mid-shutdown race (issue #1037). Test intentionally fails until shutdown recovery is implemented. 43 lines added, 0 reviewers, CI passing.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 4
Complexity: 30
Confidence: 90
Actionability: 10
keep open WIP PR to fix a race condition when reusing an instance mid-shutdown. Currently empty with no code changes; author indicates they are just starting work on the fix.

Update history

Date Change
updated
created

Related work

  • Related To: craft-providers#1037 (confidence 95%)

    This PR explicitly references and adds regression coverage for issue #1037 (race when reusing an instance mid-shutdown).

Related issues

No related issues found above the similarity threshold.