← Back to issue list

Declare more instance paths as PurePath

View original Github issue

Metadata

Project
craft-providers
Number
#135
Type
pull request
State
merged
Author
cjwatson
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 59ea19b, updating additional instance path annotations to PurePath so downstream consumers type-check correctly.

Resolution: closed resolved

Reason: PR canonical/craft-providers#135 was approved and merged to main as commit 59ea19b, completing the PurePath annotation coverage missed after #83.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Similar to https://github.com/canonical/craft-providers/pull/83, but I missed a few extra places that are needed in order for type-checking to work properly in consumers. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 59ea19b, updating additional instance path annotations to PurePath so downstream consumers type-check correctly.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR updating instance path type annotations to PurePath to fix type-checking in consumers, aligning with craft-providers#83.

Update history

Date Change
created

Related work

  • Related To: canonical/craft-providers#83 (confidence 100%)

    Earlier merged change that first declared instance paths as PurePath; #135 filled remaining gaps.

Related issues

Issue Project State Summary Similarity
#83 Declare instance paths as PurePath craft-providers merged Merged #83 in commit 411cec5 (implementation 11e96d3), changing instance-only path annotations from pathlib.Path to pathlib.PurePath.
86%