← Back to issue list

tests: use `assert_called_once_with`

View original Github issue

Metadata

Project
craft-providers
Number
#206
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #206 as commit f73f983, updating tests to use assert_called_once_with for mock call assertions.

Resolution: closed resolved

Reason: PR #206 was approved and merged into the mainline as commit f73f983, applying the requested test assertion cleanup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Minor test improvement suggested by @lengau.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #206 as commit f73f983, updating tests to use assert_called_once_with for mock call assertions.
qwen/qwen3.6-35b-a3b — closed resolved Merged test improvement to use `assert_called_once_with` instead of other assertion methods, as suggested by @lengau. Changes 1 file (+30/-43 lines).

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#563 fix(tests): replace ineffective call assertions craft-parts merged Merged PR #563 (commit 18458997) replaced ineffective assert_has_calls checks with mock_calls equality assertions in packages.deb tests, fixing #368.
74%