← Back to issue list

multipass(MultipassInstance): push files to any location

View original Github issue

Metadata

Project
craft-providers
Number
#269
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #269 (commit 49c1a63) made MultipassInstance.push_file() transfer through a temporary file before moving it to any destination, resolving #169.

Resolution: closed resolved

Reason: PR #269 merged as commit 49c1a63, implementing temporary-file transfer for push_file() and explicitly resolving issue #169. Its prerequisite refactoring, PR #268, merged as 9c18861.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- `push_file()` now follows the same design as `push_file_io()` where the file is first pushed to a temporary location and then moved to its final destination. Blocked by https://github.com/canonical/craft-providers/pull/268 Resolves https://github.com/canonical/craft-providers/issues/169 (CRAFT-1719)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #269 (commit 49c1a63) made MultipassInstance.push_file() transfer through a temporary file before moving it to any destination, resolving #169.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR updating push_file() to push to a temporary location first, then move to the final destination, matching push_file_io() design. Resolves craft-providers#169.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/craft-providers#169 (confidence 100%)

    PR #269 explicitly resolves the inability to upload files to restricted locations such as /root in Multipass instances.

  • Blocked By: canonical/craft-providers#268 (confidence 100%)

    Merged prerequisite refactoring extracted temporary-file creation for reuse by push_file(); commit 9c18861.

Related issues

Issue Project State Summary Similarity
#268 multipass(MultipassInstance): refactor push_file_io craft-providers merged Merged PR #268 as commit 9c18861, extracting _create_temp_file() from push_file_io(); no functional changes. The refactor prepared PR #269 to reuse the helper.
77%
#193 MultipassInstance: `push_file_io()` method works regardless of working dir craft-providers merged Merged PR #193 in commit a41d0b4, fixing MultipassInstance.push_file_io() to work regardless of host working-directory permissions; released in craft-providers 1.7.0.
74%
#11 multipass: introduce MultipassInstance craft-providers merged Merged PR #11 introduced MultipassInstance via commit 615064d (merge ba6cd15); Windows support remained a noted follow-up.
71%