← Back to issue list

multipass tests: cleanup after launch tests

View original Github issue

Metadata

Project
craft-providers
Number
#28
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #28 to ensure temporary Multipass instances are cleaned up after launch tests, adding explicit teardown handling in the multipass test fixture.

Resolution: closed resolved

Reason: PR #28 was merged after approval by two reviewers. Its 8-line addition and 5-line deletion updated cleanup after Multipass launch tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #28 to ensure temporary Multipass instances are cleaned up after launch tests, adding explicit teardown handling in the multipass test fixture.
stealth/space-bunny-alpha — closed resolved Merged PR #28, adding cleanup after Multipass launch tests to prevent test instances from leaking.
stealth/space-bunny-alpha — closed resolved Merged PR #28 (commit 1afc007, merge ab72f2a) adding cleanup after multipass launch tests so instances are not leaked between test runs; approved by 2 reviewers, +8/-5 lines.
qwen/qwen3.6-35b-a3b — closed resolved Implemented cleanup for multipass instances after launch tests to prevent resource leaks. Merged after approval by two reviewers.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#30 multipass: introduce auto_clean option for launch() craft-providers merged Merged PR #30 added a Multipass launch() auto_clean option that removes incompatible existing instances and launches fresh ones (merge b13242a).
77%
#22 multipass: introduce installation support craft-providers merged Merged PR #22 via commit e163f50, adding Linux and macOS Multipass installation support, error handling, tests, and CI uninstall support.
74%
#27 multipass: doc fix and require check for Multipass._run() craft-providers merged Merged PR #27 (2891d9d, merge 6c1b4fa), requiring check for Multipass._run() and correcting its documentation.
74%
#11 multipass: introduce MultipassInstance craft-providers merged Merged PR #11 introduced MultipassInstance via commit 615064d (merge ba6cd15); Windows support remained a noted follow-up.
74%
#9 multipass: introduce Multipass and MultipassError craft-providers merged PR #9 by cjp256 merged into craft-providers (commit e418497), adding a Multipass class wrapping the multipass CLI plus MultipassError, unit/integration tests (test_todo dropped), and pytest-subprocess in requirements-dev.
74%
#75 multipass: introduce ensure_multipass_is_ready() (CRAFT-438) craft-providers merged Merged PR #75 added ensure_multipass_is_ready() to verify Multipass installation and version support; merge commit 1f1ddce.
74%
#120 multipass: do not leak start command craft-providers merged Merged PR #120 in commit 79d7089, fixing Multipass so its start command is no longer leaked.
73%
#23 multipass: introduce launch to create and configure instances craft-providers merged Merged PR #23 added Multipass launch support for creating and configuring instances in commit 01457c7, merged as df00fcc after installation support from #22.
72%
#44 integration tests: consolidate lxd/multipass fixtures for reuse craft-providers merged Merged PR #44 in commit ee0f643, consolidating reusable LXD and Multipass integration-test fixtures and including a documentation fix.
72%
#16 multipass: add version() and wait_until_ready() to Multipass craft-providers merged Merged PR #16 added Multipass version() and wait_until_ready(), with the readiness helper returning the detected version.
71%