← Back to issue list

fix: require disk device in default lxd profile

View original Github issue

Metadata

Project
craft-providers
Number
#436
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #436 (commit eda59e9) merged into main. is_initialized() in craft_providers/lxd/installer.py now also requires a disk device with path "/" in the default profile, fixing #429 (CRAFT-2174) with new unit tests.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged as commit eda59e9; the new is_initialized() check for a root disk device is present in craft_providers/lxd/installer.py with unit tests test_is_initialized_no_disk_device and test_is_initialized_empty_profile. It fixes the linked issue #429.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- When checking if lxd is initialized, require the default lxd profile to contain a disk device with a path of `/`. https://github.com/canonical/craft-providers/issues/429 (CRAFT-2174)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #436 (commit eda59e9) merged into main. is_initialized() in craft_providers/lxd/installer.py now also requires a disk device with path "/" in the default profile, fixing #429 (CRAFT-2174) with new unit tests.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #436 to require a disk device with path `/` in the default LXD profile during initialization checks, resolving #429.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/craft-providers#429 (confidence 97%)

    The PR body explicitly references issue #429 (CRAFT-2174), which is now closed citing this PR and commit eda59e9.

Related issues

Issue Project State Summary Similarity
#429 Missing LXD configuration message is not friendly craft-providers closed Fixed by PR #436 (commit eda59e9), "fix: require disk device in default lxd profile": is_initialized() now also verifies a disk device with path "/" exists in the default profile, catching uninitialized LXD early. Closed per maintainer comment.
81%