← Back to issue list

Base instance does not stop when setup fails

View original Github issue

Metadata

Project
craft-providers
Number
#447
Type
issue
State
closed
Author
mr-cal
Labels
Type: Bug
Created
Updated
Closed

Current evaluation

Fixed by merged PR #996 (commit 78367c2), which stops the LXD base instance when base_configuration.setup() raises and adds regression tests.

Resolution: closed resolved

Reason: Merged PR #996, resolving commit 78367c2, added cleanup so a failed base_configuration.setup() stops the instance, with regression tests. The change closed #447 and also addressed #757.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Stop the instance if the base instance setup fails. ### Why it needs to get done There has been a regression in base handling where a failure during setup does not stop the base instance.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by merged PR #996 (commit 78367c2), which stops the LXD base instance when base_configuration.setup() raises and adds regression tests.
stealth/space-bunny-alpha — closed resolved Base setup failures now stop the base instance, resolving canonical/craft-providers#447.
qwen/qwen3.6-35b-a3b — — Fixed a bug where the base instance failed to stop after a setup failure. The resolution ensures proper termination during base initialization.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 40
Confidence: 80
Support Request: 5
close stale Bug report stating that a base instance fails to stop when setup fails. Open for nearly three years with no maintainer comments or progress, indicating the underlying architecture has likely changed.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 45
Confidence: 75
Support Request: 5
needs triage Reports a regression where the base instance fails to stop during setup. Unassigned, zero comments, and unassessed by maintainers for over 2.5 years.

Update history

Date Change
closed

Related work

  • Likely Fixed By: craft-providers#996 (confidence 100%)

    Merged fix explicitly covers failure during base configuration setup and references #447.

  • Related To: craft-providers#947 (confidence 98%)

    Earlier reproducer PR was superseded by the merged fix in #996.

  • Related To: craft-providers#757 (confidence 95%)

    Reported the same base LXD instance remaining running after an error.

Related issues

Issue Project State Summary Similarity
#996 fix: stop instance when base_configuration.setup() raises an error craft-providers merged Merged PR #996 (commit 78367c2) fixes LXD launcher leaving instances running when base_configuration.setup() raises, by wrapping setup/stop in try/finally. Closes #447 and #757; supersedes earlier #947. Adds regression tests and ruff noqa updates.
82%