← Back to issue list

util: introduce snap_cmd module for snap command helpers

View original Github issue

Metadata

Project
craft-providers
Number
#46
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #46 (commit a859b39, merged as 11a414c) added craft_providers/util/snap_cmd.py with snap command helpers (ack, known, local/remote install, pack, refresh, remove) plus unit tests.

Resolution: closed resolved

Reason: The PR was merged into main with 2 approvals and no unresolved review comments, landing commit a859b39 ("util: introduce snap_cmd module for snap command helpers") and merge commit 11a414c. The new craft_providers/util/snap_cmd.py module and tests/unit/util/test_snap_cmd.py were consumed by the later snap installer refactors (#121, #152).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add formulate_install_command() to return the snap install with specified arguments. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #46 (commit a859b39, merged as 11a414c) added craft_providers/util/snap_cmd.py with snap command helpers (ack, known, local/remote install, pack, refresh, remove) plus unit tests.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR introducing snap_cmd module with snap command helper functions including formulate_install_command(). Approved by 2 reviewers.

Update history

Date Change
created

Related work

  • Likely Fixed By: craft-providers#121 (confidence 60%)

    Merged refactor of snap installer (58abe9b/8b7dede) updated craft_providers/util/snap_cmd.py to use the pure-path helpers introduced here.

  • Related To: craft-providers#152 (confidence 55%)

    Later merged snap installer refactor (0e51d9a) touched snap_cmd.py, building on the helper module added by this PR.

Related issues

Issue Project State Summary Similarity
#45 actions: introduce helpers to install & inject snaps (CRAFT-253) craft-providers merged PR #45 (commit 5e8109c, merged via 3573b67) added snap_installer.install_from_store() and inject_from_host() helpers plus installed_snap/core20_lxd_instance test fixtures, with unit and integration tests.
74%
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
72%