← Back to issue list

Checking the compatibility tag should be more robust

View original Github issue

Metadata

Project
craft-providers
Number
#789
Type
issue
State
open
Author
bepri
Labels
Type: Enhancement
Created
Updated
Closed
—

Current evaluation

Open maintainer enhancement: compatibility checks still treat missing, None, or empty tags as compatible instead of failing or requiring investigation.

Suggested action: keep open

Reason: The current `_ensure_instance_config_compatible` implementation returns on `FileNotFoundError` and for `config is None` or a missing `compatibility_tag`; an existing test also codifies that an empty config returns successfully. The request is a valid maintainer-authored enhancement, but the phrase "some sort of error" leaves the exact failure semantics for in-progress setup to clarify, so it should remain open.

Evaluated by: mr-cal-bot

Impact: 55 Quick Win: 23 Complexity: 38 Confidence: 90 Actionability: 68

Issue body

### What needs to get done Currently, when there is no compatibility tag (missing file, set to "None", or empty config), an assumption is made that the base in question is compatible. It should instead be investigated and potentially raised as some sort of error. ### Why it needs to get done It is bad to proceed without knowing whether or not the base is compatible!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 55
Quick Win: 23
Complexity: 38
Confidence: 90
Actionability: 68
keep open Open maintainer enhancement: compatibility checks still treat missing, None, or empty tags as compatible instead of failing or requiring investigation.
stealth/space-bunny-alpha
Impact: 46
Quick Win: 16
Complexity: 48
Confidence: 79
Actionability: 66
keep open Missing, None, or empty compatibility tags can let a base be treated as compatible. This maintainer enhancement calls for stricter validation and an error, with no recorded discussion or implementation.
qwen3.6-35b-a3b-mtp-q6
Impact: 40
Quick Win: 28
Staleness: 75
Complexity: 30
Confidence: 65
Support Request: 10
needs triage Enhancement to raise an error when compatibility tag is missing instead of assuming compatibility. Open for ~1 year with no maintainer comments or action.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 30
Confidence: 80
Support Request: 5
needs triage Enhancement to make compatibility tag validation more robust by raising an error instead of assuming compatibility when the tag is missing, empty, or None. Currently unaddressed and inactive.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 30
Confidence: 80
Support Request: 5
needs triage Enhancement to make compatibility tag validation more robust. Currently, missing or empty tags default to assuming compatibility instead of raising an error. Open with no maintainer comments.

Update history

No update history recorded yet.

Related work

  • Related To: craft-providers#383 (confidence 95%)

    Both issues concern compatibility-tag handling; #383 addresses test hardcoding during tag bumps, while #789 addresses validation of missing tags.

Related issues

No related issues found above the similarity threshold.