util: do not crash on empty os-release value
Metadata
Current evaluation
External PR #790 (1-line guard against empty os-release values) was closed unmerged as superseded; its generalisation landed as PR #797 'fix(os_release): Properly lex an os-release file', commit aa5688f.
Resolution: closed superseded
Reason: Maintainer @lengau closed #790 citing PR #797 as a more general fix to the os-release parsing function. #797 was merged as commit aa5688f, which reworked the parser with a proper lexer handling empty values, mid-variable quotes and trailing commands; #790's 1-line diff was never merged (policy/lint checks were failing).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | External PR #790 (1-line guard against empty os-release values) was closed unmerged as superseded; its generalisation landed as PR #797 'fix(os_release): Properly lex an os-release file', commit aa5688f. | |
| qwen/qwen3.6-35b-a3b | — | closed superseded | Superseded by #797, which implements a more general fix for the os-release parsing function instead of the original patch. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Superseded By:
canonical/craft-providers#797
(confidence 97%)
Explicitly named by the closing maintainer comment as the general fix; merged as commit aa5688f.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #797 fix(os_release): Properly lex an os-release file | craft-providers | merged | Merged #797, replacing os-release parsing with shlex to correctly handle quoted values, empty assignments, and trailing commands. | |
| #1570 Don't fail over empty or faulty lines | snapcraft | merged | Merged PR #1570 to ignore empty or malformed /etc/os-release lines, including trailing blank lines, in commit bf216fd26. |