← Back to issue list

Warn about unused parameters in subprocess calls

View original Github issue

Metadata

Project
craft-providers
Number
#793
Type
issue
State
open
Author
bepri
Labels
Type: Enhancement
Created
Updated
Closed

Current evaluation

Enhancement to warn when kwargs are silently ignored by subprocess.Popen in LXC and Multipass exec methods. Untriaged, 378 days inactive.

Suggested action: needs triage

Reason: The issue is a valid enhancement request — the LXC `exec` method in lxc.py (lines 534-537) silently ignores `timeout` and `check` kwargs when `runner is subprocess.Popen`, and no warning is raised. However, it has had zero maintainer comments in 378 days and no assignee, so it needs triage before any action can be taken.

Impact: 45 Quick Win: 33.75 Staleness: 85 Complexity: 25 Confidence: 55 Support Request: 15

Issue body

### What needs to get done Currently, the `exec` methods of both LXC and Multipass have kwargs that are conditionally ignored. It is possible to select either `subprocess.run` or `subprocess.Popen` to launch a command, but the latter does not support all of the possible kwargs. These missing parameters get silently ignored, but a warning should be raised instead. ### Why it needs to get done To make debugging unexpected behavior easier.

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 45
Quick Win: 33.75
Staleness: 85
Complexity: 25
Confidence: 55
Support Request: 15
needs triage Enhancement to warn when kwargs are silently ignored by subprocess.Popen in LXC and Multipass exec methods. Untriaged, 378 days inactive.
qwen/qwen3.6-35b-a3b
Staleness: 75
Complexity: 20
Confidence: 85
Support Request: 5
close stale Enhancement to warn about silently ignored subprocess kwargs in LXC/Multipass exec methods. Open for ~11 months with no comments or maintainer follow-up.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 20
Confidence: 85
Support Request: 0
needs triage Enhancement to warn instead of silently ignoring unused kwargs in LXC/Multipass subprocess exec methods. Currently untriaged with no maintainer comments after 334 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 80
Complexity: 25
Confidence: 85
Support Request: 10
needs triage Enhancement to warn instead of silently ignoring unused kwargs in LXC and Multipass subprocess exec methods. Currently unassessed with no maintainer comments after ~10 months.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.