← Back to issue list

Warn about unused parameters in subprocess calls

View original Github issue

Metadata

Project
craft-providers
Number
#793
Type
issue
State
open
Author
bepri
Labels
Type: Enhancement
Created
Updated
Closed
—

Current evaluation

LXC and Multipass still omit timeout and check when exec uses subprocess.Popen, so the requested warning for silently discarded parameters remains unimplemented.

Suggested action: keep open

Reason: The maintainer-authored issue is labeled Type: Enhancement and clearly identifies both affected exec helpers. Current LXC and Multipass code passes timeout and check only in the subprocess.run branch, while the Popen branch forwards only kwargs, confirming the reported behavior and a focused implementation target.

Evaluated by: mr-cal-bot

Impact: 35 Quick Win: 20 Complexity: 30 Confidence: 93 Actionability: 82

Issue body

### What needs to get done Currently, the `exec` methods of both LXC and Multipass have kwargs that are conditionally ignored. It is possible to select either `subprocess.run` or `subprocess.Popen` to launch a command, but the latter does not support all of the possible kwargs. These missing parameters get silently ignored, but a warning should be raised instead. ### Why it needs to get done To make debugging unexpected behavior easier.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 35
Quick Win: 20
Complexity: 30
Confidence: 93
Actionability: 82
keep open LXC and Multipass still omit timeout and check when exec uses subprocess.Popen, so the requested warning for silently discarded parameters remains unimplemented.
stealth/space-bunny-alpha
Impact: 36
Quick Win: 23
Complexity: 22
Confidence: 95
Actionability: 83
keep open LXC and Multipass exec still silently drop timeout and check for subprocess.Popen; the requested diagnostic warning remains unimplemented and the maintainer-authored enhancement is inactive.
qwen3.6-35b-a3b-mtp-q6
Impact: 45
Quick Win: 34
Staleness: 85
Complexity: 25
Confidence: 55
Support Request: 15
needs triage Enhancement to warn when kwargs are silently ignored by subprocess.Popen in LXC and Multipass exec methods. Untriaged, 378 days inactive.
qwen/qwen3.6-35b-a3b
Staleness: 75
Complexity: 20
Confidence: 85
Support Request: 5
close stale Enhancement to warn about silently ignored subprocess kwargs in LXC/Multipass exec methods. Open for ~11 months with no comments or maintainer follow-up.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 20
Confidence: 85
Support Request: 0
needs triage Enhancement to warn instead of silently ignoring unused kwargs in LXC/Multipass subprocess exec methods. Currently untriaged with no maintainer comments after 334 days.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.